Date: Tue, 6 Feb 2001 18:15:36 +0200 From: Peter Pentchev <roam@orbitel.bg> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: Jordan Hubbard <jkh@winston.osd.bsdi.com>, ports@FreeBSD.org, jkh@FreeBSD.org, Edwin Groothuis <mavetju@chello.nl> Subject: Re: Request for comments [Fwd: bin/24695: [patch] pkg_info: prefix search for a package] Message-ID: <20010206181536.B406@ringworld.oblivion.bg> In-Reply-To: <20010206180825.A406@ringworld.oblivion.bg>; from roam@orbitel.bg on Tue, Feb 06, 2001 at 06:08:25PM %2B0200 References: <10197.981450491@winston.osd.bsdi.com> <3A7FC36A.1434D2CC@FreeBSD.org> <3A801D32.DE73F780@FreeBSD.org> <20010206180825.A406@ringworld.oblivion.bg>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 06, 2001 at 06:08:25PM +0200, Peter Pentchev wrote: > > The patches look great! I'll test them in an hour or two.. > Just a minor comment: in the rexs_match() function, you compile > each pattern time and again, for each package. Not that it would > matter a lot (the actual performance bottleneck would be disk I/O, > I suppose), but it could fasten things a bit if you precompiled ^^^^^^ 'speed up' would surely be better here :P Time to get some sleep ;) > all patterns into a regex_t array at the start. G'luck, Peter -- Do you think anybody has ever had *precisely this thought* before? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010206181536.B406>