Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 12 Feb 2023 23:29:01 +0100
From:      =?UTF-8?Q?Jos=C3=A9_P=C3=A9rez?= <fbl@aoek.com>
To:        Dimitry Andric <dim@freebsd.org>
Cc:        Guido Falsi <madpilot@freebsd.org>, andrew clarke <mail@ozzmosis.com>, FreeBSD Ports <ports@freebsd.org>
Subject:   Re: editors/uemacs fails to biuld on 14.0-CURRENT 1400079
Message-ID:  <4826f5f6531cd30c42c0882cbda55fce@mail.yourbox.net>
In-Reply-To: <8EA8CA09-BBD4-455A-8946-57A2755690B3@FreeBSD.org>
References:  <8aceaed7bb0323fc53143a8befd35170@mail.yourbox.net> <20230211111245.o3qjm3oyncivtipu@ozzmosis.com> <aac4282d-da2a-17dc-28cd-f4b511359c96@FreeBSD.org> <8EA8CA09-BBD4-455A-8946-57A2755690B3@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
El 2023-02-12 11:09, Dimitry Andric escribió:
...
> tl;dr:
> 
> * old software breaking with -Wimplicit-function-declaration and
>   -Wimplicit-int errors can be fixed by setting USE_CSTD=gnu89 (or
>   whatever is necessary to make it use -std=gnu89).
> * software breaking with -Wint-conversion should ideally have their
>   integer-to-pointer or pointer-to-integer conversions fixed, but
>   otherwise the error can be silened with -Wno-int-conversion.

Dimitry, thank you for the detailed insight. I am using your suggestions 
to fix other ports as well.

I could not manage to have USE_CSTD work, not for uemacs nor for other 
ports, so this patch works for me.

diff --git a/editors/uemacs/Makefile b/editors/uemacs/Makefile
index f999cc978685..48111ffb8824 100644
--- a/editors/uemacs/Makefile
+++ b/editors/uemacs/Makefile
@@ -19,6 +19,8 @@ NO_WRKSUBDIR= yes
  USES=          dos2unix ncurses zip
  EXTRACT_BEFORE_ARGS=   -Lq

+CFLAGS+=       -Wno-int-conversion
+
  post-patch:
         @${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|g" 
${WRKSRC}/src/*.c
         @${REINPLACE_CMD} -e 's|-ltermcap|${LDFLAGS} -lncurses|g' \

BR,

-- 
José Pérez



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4826f5f6531cd30c42c0882cbda55fce>