Date: Wed, 24 Nov 2021 19:24:40 +0100 From: Piotr Kubaj <pkubaj@anongoth.pl> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 3a60869237b8 - main - Add assembly optimized code for OpenSSL on powerpc, powerpc64 and powerpc64le Message-ID: <YZ6DaBSZIT%2BKVsR%2B@KGPE-D16> In-Reply-To: <f24e57bd-139b-9c39-ebe8-6adaddcd726e@FreeBSD.org> References: <202111232227.1ANMRCYk070382@gitrepo.freebsd.org> <f24e57bd-139b-9c39-ebe8-6adaddcd726e@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
OK, it looks like ossl uses fpu_kern functions and those are available only an aarch64, amd64 and i386:
cc -O2 -pipe -fno-common -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -include /usr/obj/usr/src/powerpc.powerpc64/sys/modules/ossl/opt_global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -fPIC -mlongcall -fno-omit-frame-pointer -fdebug-prefix-map=./machine=/usr/src/sys/powerpc/include -MD -MF.depend.ossl.o -MTossl.o -mno-altivec -msoft-float -mabi=elfv2 -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length -std=iso9899:1999 -c /usr/src/sys/crypto/openssl/ossl.c -o ossl.o
/usr/src/sys/crypto/openssl/ossl.c:190:4: error: implicit declaration of function 'fpu_kern_enter' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
fpu_kern_enter(curthread, NULL, FPU_KERN_NOCTX);
^
/usr/src/sys/crypto/openssl/ossl.c:190:36: error: use of undeclared identifier 'FPU_KERN_NOCTX'
fpu_kern_enter(curthread, NULL, FPU_KERN_NOCTX);
^
/usr/src/sys/crypto/openssl/ossl.c:193:4: error: implicit declaration of function 'fpu_kern_leave' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
fpu_kern_leave(curthread, NULL);
^
/usr/src/sys/crypto/openssl/ossl.c:193:4: note: did you mean 'fpu_kern_enter'?
/usr/src/sys/crypto/openssl/ossl.c:190:4: note: 'fpu_kern_enter' declared here
fpu_kern_enter(curthread, NULL, FPU_KERN_NOCTX);
^
/usr/src/sys/crypto/openssl/ossl.c:214:6: error: implicit declaration of function 'is_fpu_kern_thread' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
if (is_fpu_kern_thread(0)) {
^
/usr/src/sys/crypto/openssl/ossl.c:217:3: error: implicit declaration of function 'fpu_kern_enter' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
fpu_kern_enter(curthread, NULL, FPU_KERN_NOCTX);
^
/usr/src/sys/crypto/openssl/ossl.c:217:35: error: use of undeclared identifier 'FPU_KERN_NOCTX'
fpu_kern_enter(curthread, NULL, FPU_KERN_NOCTX);
^
/usr/src/sys/crypto/openssl/ossl.c:263:3: error: implicit declaration of function 'fpu_kern_leave' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
fpu_kern_leave(curthread, NULL);
^
7 errors generated.
AFAIK porting those is not easy and it's certainly above my pay grade.
On 21-11-24 08:15:26, John Baldwin wrote:
> On 11/23/21 2:27 PM, Piotr Kubaj wrote:
> > The branch main has been updated by pkubaj (ports committer):
> >
> > URL: https://cgit.FreeBSD.org/src/commit/?id=3a60869237b8b315fe66497cf5299ec08b688533
> >
> > commit 3a60869237b8b315fe66497cf5299ec08b688533
> > Author: Piotr Kubaj <pkubaj@FreeBSD.org>
> > AuthorDate: 2021-11-22 02:28:46 +0000
> > Commit: Piotr Kubaj <pkubaj@FreeBSD.org>
> > CommitDate: 2021-11-23 22:26:53 +0000
> >
> > Add assembly optimized code for OpenSSL on powerpc, powerpc64 and powerpc64le
> >
> > Summary:
> > 1. https://github.com/openssl/openssl/commit/34ab13b7d8e3e723adb60be8142e38b7c9cd382a
> > needs to be merged for ELFv2 support on big-endian.
> > 2. crypto/openssl/crypto/ppccap.c needs to be patched.
> > Same reason as in https://github.com/openssl/openssl/pull/17082.
>
> Have you looked at adding powerpc support to ossl(4)? It should be fairly simple
> (just adding the right asm files in Makefiles and the powerpc equivalent of
> OSSL_cpuid).
>
> --
> John Baldwin
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmGeg2gACgkQelmbhSCD
nJ1eVBAApv3riGUqY+aVDZT4uNSX61jyAcn7uSq43PZdqFoqXO1uQ/iNfAwx4kas
9w7OshIWJT4EwH9RDFh1KUqseOdLQzbCj35/qZclWxIQO+qbCVti8yHkhdj4BgY9
pSaxL3NOHq20+JlzqosUd1cTL/vnX/hhu6na2cf4w3vriPGAe5bNKQbj642LonET
QLUBcMNjQE7E6tI8x+wm3gsAexx/hhz92JlpDIrwoWKf0PxagMDu00HqHqlssOZ0
DuASEg6eSkf4ctuVwusnuLgmlKG7O9mrMLzN3mCLHNKi5jAbSPrETOux9bcAOAjH
kRQN4ZespyB9xxF5s3LQTHXF58Ha9ziWkiqZTVa0GkdVYFNC4+jMYZhk6fTNSBol
Exuj97J9xT5btvMUMBptbnpMhN664Jyo+3Yh9zdvuSbM3hlYPu/oDHINcE3CEzpB
acDj72bNluyAI+I3kBf0vtQRbAxpAbk3mwiIk8PxIYZYtlVYB9p+dTbvAyYKOzhJ
C0Y6fcBNDmBmAirvMNNbWBulYAf5cYs6l8v0aLgLuQfr8aRawr0AUy+JpDsqwdkr
aKt+S13wqS94xQB1E8wAEQKBoKPyYlXFN4K4OfSONjrm8c33CMzeCU1grY+Bq91E
0UMUa195pDCcpAWBabrSaEJcyLxSOnn7XXbSHN5vCjbYlYBe9PA=
=uQmv
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YZ6DaBSZIT%2BKVsR%2B>