Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 7 Nov 2023 11:23:04 GMT
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 96cb1d70008e - main - linuxkpi linux_work: use 'true' instead of 'non-zero'
Message-ID:  <202311071123.3A7BN4SE034137@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by kib:

URL: https://cgit.FreeBSD.org/src/commit/?id=96cb1d70008e6d42750e95135316cafd6899384f

commit 96cb1d70008e6d42750e95135316cafd6899384f
Author:     Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2023-11-07 10:56:39 +0000
Commit:     Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2023-11-07 10:58:21 +0000

    linuxkpi linux_work: use 'true' instead of 'non-zero'
    
    Submitted by:   markj
    MFC after:      1 week
    Differential revision:  https://reviews.freebsd.org/D42468
---
 sys/compat/linuxkpi/common/src/linux_work.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/sys/compat/linuxkpi/common/src/linux_work.c b/sys/compat/linuxkpi/common/src/linux_work.c
index 888ac97dbff6..c62302ad2346 100644
--- a/sys/compat/linuxkpi/common/src/linux_work.c
+++ b/sys/compat/linuxkpi/common/src/linux_work.c
@@ -206,7 +206,7 @@ linux_flush_rcu_work(struct rcu_work *rwork)
 
 /*
  * This function queues the given work structure on the given
- * workqueue after a given delay in ticks. It returns non-zero if the
+ * workqueue after a given delay in ticks. It returns true if the
  * work was successfully [re-]queued. Else the work is already pending
  * for completion.
  */
@@ -230,7 +230,7 @@ linux_queue_delayed_work_on(int cpu, struct workqueue_struct *wq,
 	switch (linux_update_state(&dwork->work.state, states)) {
 	case WORK_ST_EXEC:
 	case WORK_ST_CANCEL:
-		if (delay == 0 && linux_work_exec_unblock(&dwork->work) != 0) {
+		if (delay == 0 && linux_work_exec_unblock(&dwork->work)) {
 			dwork->timer.expires = jiffies;
 			res = true;
 			goto out;
@@ -468,7 +468,7 @@ linux_cancel_delayed_work(struct delayed_work *dwork)
 
 /*
  * This function cancels the given work structure in a synchronous
- * fashion. It returns non-zero if the work was successfully
+ * fashion. It returns true if the work was successfully
  * cancelled. Else the work was already cancelled.
  */
 static bool



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202311071123.3A7BN4SE034137>