Date: Sun, 21 Jul 2024 11:07:46 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, "arrowd@FreeBSD.org" <arrowd@freebsd.org> Subject: Re: git: 06601897e5cd - main - framework: reintroduce the feature enabling code Message-ID: <4f2ce2b474bd4d522adbf277c3418393@mail.infomaniak.com> In-Reply-To: <d66b209388c08a537cef775a5d5d7891@mail.infomaniak.com> References: <202404120754.43C7slbr026326@gitrepo.freebsd.org> <12af8e210220224883a7856115f61be9@mail.infomaniak.com> <6kivt3yarts23vqyv277vqrw6dhswo4hilbdkspvnaz544mtvc@yiyqgdtnp6y7> <457bab3436f42fd12d80beb16e067cf0@mail.infomaniak.com> <4cvwsu7vebcrzorvjygkhzefbnjq2cegtobxbybxpglltsla3k@637dblgngbon> <d66b209388c08a537cef775a5d5d7891@mail.infomaniak.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On 2024-07-13T18:49:27.000+02:00, Daniel Engberg <daniel.engberg.lists@pyret.net> wrote: > On 2024-07-13T16:30:31.000+02:00, Mathieu Arnold <mat@freebsd.org> > > wrote: > >> On Sat, Jul 13, 2024 at 02:04:48PM GMT, Daniel Engberg wrote: >> >>> On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold >>> >>> <mat@freebsd.org> >>> >>> wrote: >>> >>>> On Sat, Jul 13, 2024 at 06:11:04AM GMT, Daniel Engberg wrote: >>>> >>>>> Hi, >>>>> >>>>> This changes so LTO option is no longer applied to Rust >>>>> >>>>> (cargo) >>>>> >>>>> ports >>>>> >>>>> BY DEFAULT causing a regresssion, please fix. >>>> >>>> As it has been three months, nobody complained something was >>>> >>>> broken >>>> >>>> so, >>>> >>>> I don't think anything is actually broken. >>>> >>>> LTO as are a few other features like SSP are user facing >>>> >>>> features, >>>> >>>> not a >>>> >>>> porters facing options, it means, it's up to the person doing >>>> >>>> the >>>> >>>> building to choose wether to enable it or not, it is **not** >>>> up >>>> >>>> to >>>> >>>> the >>>> >>>> person porting the software to forcefully enable it. >>>> >>>> -- >>>> >>>> Mathieu Arnold >>> >>> Hi, >>> >>> Likely because this pretty much silently went by because it was >>> >>> posted >>> >>> on Phab and you only CCed bapt. It's been enabled since Jan >>> 2023 >>> >>> (https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?id=967022fd812cf67dec264ee4e53bd016b69e7a2b) >>> >>> and tested/discussed here https://reviews.freebsd.org/D36736 >>> >>> before >>> >>> being enabled/committed. I noticed it now while updating a Rust >>> >>> (cargo-based) port. >> >> Mmmm, yes, I know about that, and I agree, this commits reverts >> this >> >> behavior. >> >> Because choosing to build with or without LTO is a user facing >> >> feature, >> >> not a porter facing feature, so, it has to be set by people >> building >> >> the >> >> things, not by the framework or a port. >> >> -- >> >> Mathieu Arnold > > Hi, > > Given that it was commonly agreed upon as a sane default I don't see > > how your opinion in this case weights more. That being said, any > > option could be defined as user facing option some of which are > > already agreed upon as sane such as DOCS and EXAMPLES. > > Best regards, > > Daniel Hi, Jsuit a heads up, given that I haven't recieved any further mail regading this change or further explanation I'll enable LTO again for Cargo ports as agreed upon in https://reviews.freebsd.org/D36736 later today. Best regards, Daniel (diizzyy@) [-- Attachment #2 --] <html><body><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">On 2024-07-13T18:49:27.000+02:00, Daniel Engberg <daniel.engberg.lists@pyret.net> wrote:<br></div><div class="ik_mail_quote answerContentMessage"><blockquote class="ws-ng-quote"><pre style="white-space: normal;"><div>On 2024-07-13T16:30:31.000+02:00, Mathieu Arnold <<a class="defaultMailLink" href="mailto:mat@freebsd.org">mat@freebsd.org</a>><br></div><div>wrote:<br></div><div><br></div><blockquote class="ws-ng-quote"><div> On Sat, Jul 13, 2024 at 02:04:48PM GMT, Daniel Engberg wrote:<br></div><blockquote class="ws-ng-quote"><div> On 2024-07-13T08:47:47.000+02:00, Mathieu Arnold<br></div><div> <<a class="defaultMailLink" href="mailto:mat@freebsd.org">mat@freebsd.org</a>><br></div><div> <br></div><div> wrote:<br></div><div> <br></div><blockquote class="ws-ng-quote"><div> On Sat, Jul 13, 2024 at 06:11:04AM GMT, Daniel Engberg wrote:<br></div><div> <br></div><blockquote class="ws-ng-quote"><div> Hi,<br></div><div> <br></div><div> This changes so LTO option is no longer applied to Rust<br></div><div> (cargo)<br></div><div> <br></div><div> ports<br></div><div> <br></div><div> BY DEFAULT causing a regresssion, please fix.<br></div></blockquote><div> <br></div><div> As it has been three months, nobody complained something was<br></div><div> broken<br></div><div> <br></div><div> so,<br></div><div> <br></div><div> I don't think anything is actually broken.<br></div><div> <br></div><div> LTO as are a few other features like SSP are user facing<br></div><div> features,<br></div><div> <br></div><div> not a<br></div><div> <br></div><div> porters facing options, it means, it's up to the person doing<br></div><div> the<br></div><div> <br></div><div> building to choose wether to enable it or not, it is **not** up<br></div><div> to<br></div><div> <br></div><div> the<br></div><div> <br></div><div> person porting the software to forcefully enable it.<br></div><div> <br></div><div> -- <br></div><div> <br></div><div> Mathieu Arnold<br></div></blockquote><div> <br></div><div> Hi,<br></div><div> <br></div><div> Likely because this pretty much silently went by because it was<br></div><div> posted<br></div><div> <br></div><div> on Phab and you only CCed bapt. It's been enabled since Jan 2023<br></div><div> <br></div><div> (<a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?id=967022fd812cf67dec264ee4e53bd016b69e7a2b" target="_blank">https://cgit.freebsd.org/ports/commit/Mk/Uses/cargo.mk?id=967022fd812cf67dec264ee4e53bd016b69e7a2b</a>)<br></div><div>; <br></div><div> and tested/discussed here <a data-ik="ik-secure" rel="noopener noreferrer" class="defaultMailLink" href="https://reviews.freebsd.org/D36736" target="_blank">https://reviews.freebsd.org/D36736</a><br></div><div>; before<br></div><div> <br></div><div> being enabled/committed. I noticed it now while updating a Rust<br></div><div> <br></div><div> (cargo-based) port.<br></div></blockquote><div> <br></div><div> Mmmm, yes, I know about that, and I agree, this commits reverts this<br></div><div> <br></div><div> behavior.<br></div><div> <br></div><div> Because choosing to build with or without LTO is a user facing<br></div><div> feature,<br></div><div> <br></div><div> not a porter facing feature, so, it has to be set by people building<br></div><div> the<br></div><div> <br></div><div> things, not by the framework or a port.<br></div><div> <br></div><div> -- <br></div><div> <br></div><div> Mathieu Arnold<br></div></blockquote><div> <br></div><div>Hi,<br></div><div><br></div><div>Given that it was commonly agreed upon as a sane default I don't see<br></div><div>how your opinion in this case weights more. That being said, any<br></div><div>option could be defined as user facing option some of which are<br></div><div>already agreed upon as sane such as DOCS and EXAMPLES.<br></div><div><br></div><div>Best regards,<br></div><div><br></div><div>Daniel<br></div></pre></blockquote></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Hi,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Jsuit a heads up, given that I haven't recieved any further mail regading this change or further explanation I'll enable LTO again for Cargo ports as agreed upon in <a href="https://reviews.freebsd.org/D36736">https://reviews.freebsd.org/D36736</a>; later today.<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px"><br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Best regards,<br></div><div style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; font-size: 14px">Daniel (diizzyy@)<br></div></body></html>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4f2ce2b474bd4d522adbf277c3418393>