Date: Wed, 6 Mar 2002 11:27:27 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: "Jan L. Peterson" <jlp@softhome.net> Cc: Ian Dowse <iedowse@maths.tcd.ie>, freebsd-stable@FreeBSD.ORG Subject: Re: crashes on 4.5-RELEASE Message-ID: <200203061927.g26JRRH32588@apollo.backplane.com> References: <200202232021.aa04276@salmon.maths.tcd.ie> <20020304233509.5BFD0422D8@mail.flipdog.com> <200203050004.g25042F91389@apollo.backplane.com> <20020306191109.5FF92422D8@mail.flipdog.com>
next in thread | previous in thread | raw e-mail | index | archive | help
That is excellent news! I'm crossing my fingers that it continues to
not panic.
I have MFC'd this patch to -stable (actually did it yesterday since it
seems sensible).
I think there may still be a bug in xl0, probably something that goes
wrong when xl0 is unable to allocate a new mbuf. This patch makes that
far less likely to occur under certain circumstances.
-Matt
Matthew Dillon
<dillon@backplane.com>
:I have not had a crash since applying this patch:
:
:RCS file: /home/ncvs/src/sys/kern/uipc_socket.c,v
:retrieving revision 1.68.2.18
:diff -u -r1.68.2.18 uipc_socket.c
:--- uipc_socket.c 13 Feb 2002 00:43:10 -0000 1.68.2.18
:+++ uipc_socket.c 5 Mar 2002 00:02:59 -0000
:@@ -525,7 +525,7 @@
: if ((atomic && resid > so->so_snd.sb_hiwat) ||
: clen > so->so_snd.sb_hiwat)
: snderr(EMSGSIZE);
:- if (space < resid + clen && uio &&
:+ if (space < resid + clen &&
: (atomic || space < so->so_snd.sb_lowat || space < clen)) {
: if (so->so_state & SS_NBIO)
: snderr(EWOULDBLOCK);
:
:even with INVARIANTS turned off. Nor have I seen an xl0 watchdog
:timeout.
:
:I'm going to play with it a bit more before I call it good, but it's
:certainly looking better than before.
:
:I'll keep my debugging kernel in place, too, so that I can get a core
:dump and symbol table if I see another crash.
:
:I'll keep you all posted.
:
: -jan-
:--
:Jan L. Peterson
:<jlp@softhome.net>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200203061927.g26JRRH32588>