Date: Tue, 20 Dec 2011 06:53:50 +0000 From: Chris Rees <crees@freebsd.org> To: Doug Barton <dougb@freebsd.org> Cc: cvs-ports@freebsd.org, freebsd-xfce@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/sysutils/xfce4-utils Makefile Message-ID: <CADLo83_1qvngB3-yi=UVbAqfbKQqzoY%2Bty7fPHjxqeGmr_46eg@mail.gmail.com> In-Reply-To: <4EEFD2B8.1050006@FreeBSD.org> References: <201112181751.pBIHpivv027591@repoman.freebsd.org> <4EEF0AF1.20501@FreeBSD.org> <CADLo838TKwEZwLfXsAYmXowKweM8MiC5=BT5NFGyegWyubcX=A@mail.gmail.com> <4EEFD2B8.1050006@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 20 Dec 2011 00:11, "Doug Barton" <dougb@freebsd.org> wrote:
>
> On 12/19/2011 02:03, Chris Rees wrote:
> >
> > On 19 Dec 2011 09:59, "Doug Barton" <dougb@freebsd.org
> > <mailto:dougb@freebsd.org>> wrote:
> >>
> >> Thanks, that's 1/3 of the job done. :) =A0The problem is that the curr=
ent
> >> OPTION creates the false idea that the only way you can lock your scre=
en
> >> is to use xlockmore.
> >>
> >> Perhaps you missed my followup where I mentioned that the next step
> >> would be to add an OPTION for xscreensaver as well, and the logic to
> >> avoid having them both defined.
> >
> > I'll look at that later.
>
> Thanks. In answer to your question avoiding having both enabled would be
> nice since it avoids duplicate, unnecessary redundancy.
>
> >> Better yet would be to detect if one or the other is already installed=
,
> >> and default the OPTIONS accordingly.
> >
> > Autodetection in ports? No thanks!
>
> I didn't suggest autodetecting for the dependencies, I suggested it for
> the OPTIONS. That's been done for a long time, and ideally should be how
> it's always done.
Ok... a pointer on how that's done would be good.
The only way I can think of would be:
.if exists(${LOCALBASE}/bin/xlock)
OPTIONS+=3D XLOCK "Use xlock for 'lock screen'" on
.else
OPTIONS+=3D XLOCK "Use xlock for 'lock screen'" off
.endif
which would be great if LOCALBASE were actually defined before
bsd.port.options.mk.
I can't see a way to do this. Do you have an example port?
Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83_1qvngB3-yi=UVbAqfbKQqzoY%2Bty7fPHjxqeGmr_46eg>