Date: Mon, 21 Aug 2006 07:07:53 -0400 From: Kris Kennaway <kris@obsecurity.org> To: "Raphael H. Becker" <rabe@p-i-n.com> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Florent Thoumie <flz@freebsd.org> Subject: Re: PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c) Message-ID: <20060821110753.GA99959@xor.obsecurity.org> In-Reply-To: <20060821080945.A48690@p-i-n.com> References: <200601161951.k0GJpfNx017833@repoman.freebsd.org> <20060821080945.A48690@p-i-n.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Mon, Aug 21, 2006 at 08:09:45AM +0200, Raphael H. Becker wrote:
>
> Hi Florent,
>
> PKGDIR is ambiguous in the context of ports and packages.
>
> I set PKGDIR=/some/where/my/pkg in my /etc/profile which causes the
> ports to fail badly creating any packages:
>
> It is used in ports/Mk/bsd.port.mk:
> # PKGDIR - A directory containing any package creation
> # files.
> # Default: ${MASTERDIR}
> [...]
> PKGDIR?= ${MASTERDIR}
>
> Havin set PKGDIR statically is a very bad idea here.
Yes, PKGDIR is incorrect in this usage. The documented place where
packages are stored is:
# PACKAGES - A top level directory where all packages go (rather than
# going locally to each port).
# Default: ${PORTSDIR}/packages
#
> > flz 2006-01-16 19:51:41 UTC
> >
> > FreeBSD src repository (ports committer)
> >
> > Modified files: (Branch: RELENG_5)
> > usr.sbin/pkg_install/info perform.c pkg_info.1 info.h main.c
> > usr.sbin/pkg_install/add main.c add.h pkg_add.1 perform.c
> > usr.sbin/pkg_install/lib lib.h url.c
> > Log:
> > MFC:
> >
> > Add -K option to pkg_add and pkg_info.
> > This option saves packages to PKGDIR (if defined or current directory by default)
> > as they are downloaded.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)
iD8DBQFE6ZQJWry0BWjoQKURAh2PAJ4k5pAjhz6u+7bTJ5qVXUW9hoBEfACgmEVs
WoPSKbyXkgFYUpvFQFhEX84=
=6OBB
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060821110753.GA99959>