Date: Mon, 7 Dec 2015 20:32:05 +0100 From: Oliver Pinter <oliver.pinter@hardenedbsd.org> To: "Conrad E. Meyer" <cem@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291907 - head/sys/vm Message-ID: <CAPQ4fftXQ32h4ELrdUdB=21LXuEPE=fZuZHmjqKg_bNUvacrgg@mail.gmail.com> In-Reply-To: <201512061746.tB6HkCWb072736@repo.freebsd.org> References: <201512061746.tB6HkCWb072736@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/6/15, Conrad E. Meyer <cem@freebsd.org> wrote: > Author: cem > Date: Sun Dec 6 17:46:12 2015 > New Revision: 291907 > URL: https://svnweb.freebsd.org/changeset/base/291907 > > Log: > vm_fault_hold: handle vm_page_rename failure > > On vm_page_rename failure, fix a missing object unlock and a double free > of > a page. > > First remove the old page, then rename into other page into first_object, > then free the old page. This avoids the problem on rename failure. This > is > a little ugly but seems to be the most straightforward solution. > > Tested with: > $ sysctl debug.fail_point.uma_zalloc_arg="1%return" > $ kyua test -k /usr/tests/sys/Kyuafile > > Submitted by: Ryan Libby <rlibby@gmail.com> > Reviewed by: kib > Seen by: alc > Sponsored by: EMC / Isilon Storage Division > Differential Revision: https://reviews.freebsd.org/D4326 > > Modified: > head/sys/vm/vm_fault.c > > Modified: head/sys/vm/vm_fault.c > Hi Conrad! You have any plan to MFC this commit?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPQ4fftXQ32h4ELrdUdB=21LXuEPE=fZuZHmjqKg_bNUvacrgg>