Date: Mon, 13 Jun 2016 20:28:50 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: "Simon J. Gerraty" <sjg@juniper.net> Cc: Mark Millard <markmi@dsl-only.net>, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: 11.0 -r301815 to -r310873 using WITH_META_MODE=yes : an empty filename failure Message-ID: <99ee7f26-573f-2aeb-c569-728602bb3593@FreeBSD.org> In-Reply-To: <57295.1465874334@kaos.jnpr.net> References: <85435AE2-3F2C-4330-9751-729D99716A8C@dsl-only.net> <65e079c5-6b69-1b94-6bc8-ee32269cc98c@FreeBSD.org> <57295.1465874334@kaos.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/13/16 8:18 PM, Simon J. Gerraty wrote:
> Bryan Drewery <bdrewery@freebsd.org> wrote:
>>>> ${_FIRM}: ${.CURDIR}/../../../../contrib/dev/drm2/radeonkmsfw/${_FIRM}.uu
>>>> uudecode -p $? > ${.TARGET}
>
> Targets like this that use $? or ${.OODATE} are a bad fit with META mode.
>
> If the normal make rules think the target is up to date, .OODATE will be
> empty, thus if meta_oodate says the target is out-of-date, the script
> will run with no args - because $? expands to nothing.
>
> So either the use of $? should be replaced with ${.ALLSRC} or something
> else that will be consistent, or the target should be marked .NOMETA
>
> FYI we can [ab]use ${.OODATE} as a token to prevent a line of a script
> from being compared - meta mode knows that the value of .OODATE is
> inconsistent so should not be compared... thus putting
> ${.OODATE:MNO_META_CMP} on a line expands to nothing - no impact on the
> command but still tells meta_oodate to ignore that line for comparison
> purposes.
>
The problem is missing-meta requiring a .meta file here. The $?/.OODATE
comparison exception is only used meta_oodate() if there is already a
.meta file, not for the new missing .meta logic.
--
Regards,
Bryan Drewery
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?99ee7f26-573f-2aeb-c569-728602bb3593>