Date: Wed, 30 Sep 2015 12:54:26 -0700 From: Xin Li <delphij@delphij.net> To: Robert Blayzor <rblayzor.bulk@inoc.net>, d@delphij.net Cc: freebsd-security@freebsd.org Subject: Re: FreeBSD Security Advisory FreeBSD-SA-15:24.rpcbind Message-ID: <560C3DF2.5070608@delphij.net> In-Reply-To: <AC5D1DD3-8AD9-49F8-9ECB-5B239E1B97F6@inoc.net> References: <20150929183942.569F311FD@freefall.freebsd.org> <B821DB04-67A9-4F7C-85E1-8ABCF72C6D46@inoc.net> <560C33B7.70100@delphij.net> <AE3C0342-75F1-4703-A685-561A303C3C76@inoc.net> <560C39B3.1020806@delphij.net> <AC5D1DD3-8AD9-49F8-9ECB-5B239E1B97F6@inoc.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--CQtUxqDjeRTbUK0Ef4FfbR2ttF6vBjswJ
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Hi,
Can you make this change and see if it helps?
Index: rpcb_svc_com.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- rpcb_svc_com.c (revision 288421)
+++ rpcb_svc_com.c (working copy)
@@ -1052,7 +1052,7 @@ static bool_t
netbuf_copybuf(struct netbuf *dst, const struct netbuf *src)
{
- assert(dst->buf =3D=3D NULL);
+ assert(dst->len =3D=3D 0 || dst->buf =3D=3D NULL);
if ((dst->buf =3D malloc(src->len)) =3D=3D NULL)
return (FALSE);
Cheers,
--=20
Xin LI <delphij@delphij.net> https://www.delphij.net/
FreeBSD - The Power to Serve! Live free or die
--CQtUxqDjeRTbUK0Ef4FfbR2ttF6vBjswJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1.8 (FreeBSD)
iQIcBAEBCgAGBQJWDD3yAAoJEJW2GBstM+nslVQQAIW9HZzOes88wacqtiQBLIUm
KKXntKxy+ChLYTJoVITFJnAwy/4UZ3OuscR5A+eOJMrY0UEgokPbWLlEcxcu+JX6
wc3MNVpS/tntHgpliv72delFbnCjCkgRtltZb7iXUOXat+6SNcj3yah96N1L4BEG
LDeLXKbNjAhloJuzqZHEx++r069NyAo8KuKSlGOKMgcTcEqc/1B1qaD+ZZjKgRDm
1qw7rrgTesUa6ExRfoJKpdHUCNPTTqEKLt/lgw9ALJpghEb50lVhuq7KA2U8mWLT
vNsxxjjRajgftNfR6PpwVhRPTAfTneMjdWY0jU7bWkY718iic/MJZF8w7AcRyur0
s+5Ji8mPmXN3EJEvT3a7KwbeNDowpt7sa1O+rEKmCIP8bmzTlREpzr9gett5wd0x
JkzWdqLdoSbuJeDrCpZAyQBdw8Pg90o2A9I3K1TTh5dwkFH0kdrA4+L4ZGnmmFfw
rrySj0TQ7QOqbv4HpwQJaSrkctBoCv08molX9sMYgIbqHkcy5Wx0rGiQETaD8+mF
5S0LOC93kvA7/Fq6ue6gSQkogpyK5etiwz2J9oybLazeuOC7ehGAuJUj3zKAJEGd
W3rc9UeBtVMYe8VA6R/5PZzC+pTk1ldMf02MSWqZMTs7FvndZcNyufpUpYfqs+jc
hd1JlMkYlJUk6MqLu6tX
=kjD9
-----END PGP SIGNATURE-----
--CQtUxqDjeRTbUK0Ef4FfbR2ttF6vBjswJ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?560C3DF2.5070608>