Date: Mon, 4 Feb 2019 16:51:20 +0000 From: Steven Hartland <steven.hartland@multiplay.co.uk> To: Alexander Motin <mav@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343745 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <aa9faa98-c3f1-c609-40d0-a234da419721@multiplay.co.uk> In-Reply-To: <201902041613.x14GDf4k022902@repo.freebsd.org> References: <201902041613.x14GDf4k022902@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04/02/2019 16:13, Alexander Motin wrote: > Author: mav > Date: Mon Feb 4 16:13:41 2019 > New Revision: 343745 > URL: https://svnweb.freebsd.org/changeset/base/343745 > > Log: > Add missed tunables/sysctls for some new vdev variables. > > While there, make few existing sysctls writeable, since there is no reason > not to. > > MFC after: 1 week > > Modified: > head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c > > Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c > ============================================================================== > --- head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c Mon Feb 4 16:02:03 2019 (r343744) > +++ head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev.c Mon Feb 4 16:13:41 2019 (r343745) > @@ -165,29 +165,38 @@ static vdev_ops_t *vdev_ops_table[] = { > > /* target number of metaslabs per top-level vdev */ > int vdev_max_ms_count = 200; > -SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, max_ms_count, CTLFLAG_RDTUN, > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, max_ms_count, CTLFLAG_RWTUN, > &vdev_max_ms_count, 0, > - "Maximum number of metaslabs per top-level vdev"); > + "Target number of metaslabs per top-level vdev"); > > /* minimum number of metaslabs per top-level vdev */ > int vdev_min_ms_count = 16; > -SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, min_ms_count, CTLFLAG_RDTUN, > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, min_ms_count, CTLFLAG_RWTUN, > &vdev_min_ms_count, 0, > "Minimum number of metaslabs per top-level vdev"); > > /* practical upper limit of total metaslabs per top-level vdev */ > int vdev_ms_count_limit = 1ULL << 17; > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, max_ms_count_limit, CTLFLAG_RWTUN, > + &vdev_ms_count_limit, 0, > + "Maximum number of metaslabs per top-level vdev"); > > /* lower limit for metaslab size (512M) */ > int vdev_default_ms_shift = 29; > -SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, default_ms_shift, CTLFLAG_RDTUN, > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, default_ms_shift, CTLFLAG_RWTUN, > &vdev_default_ms_shift, 0, > - "Shift between vdev size and number of metaslabs"); > + "Default shift between vdev size and number of metaslabs"); > > /* upper limit for metaslab size (256G) */ > int vdev_max_ms_shift = 38; > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, max_ms_shift, CTLFLAG_RWTUN, > + &vdev_max_ms_shift, 0, > + "Maximal shift between vdev size and number of metaslabs"); It's a just a nit but I believe this should Maximum, like the others, instead of Maximal. > > boolean_t vdev_validate_skip = B_FALSE; > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, validate_skip, CTLFLAG_RWTUN, > + &vdev_validate_skip, 0, > + "Bypass vdev validation"); > > /* > * Since the DTL space map of a vdev is not expected to have a lot of >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aa9faa98-c3f1-c609-40d0-a234da419721>