Date: Tue, 25 Jun 2019 00:21:25 -0600 From: Warner Losh <imp@bsdimp.com> To: Warner Losh <imp@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r349352 - in head: etc/mtree include lib lib/libnandfs sbin sbin/camcontrol sbin/nandfs sbin/newfs_nandfs share/man/man4 share/man/man5 share/mk stand stand/arm/uboot stand/common stand... Message-ID: <CANCZdfobKcAjw5Z2u6H7hgZpWTvg5mY1Uz4Ls9MMv98F8LoBWg@mail.gmail.com> In-Reply-To: <201906250450.x5P4o9oR015946@repo.freebsd.org> References: <201906250450.x5P4o9oR015946@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This commit accidentally reverted r349333, r349334, r349335, r349336, r349339, r349340, r349341 and r349342. I rebased after one of the make universes I did to proof this set and something must have gone wrong and I lost these changes. I noticed while committing, but didn't hit ^C fast enough to prevent the damage it seems. I've reapplied those changes rather than revert this commit for two reasons: first, reverting commits that delete things has caused me trouble in the past. Second, I judge that to be less repo-churn than doing the revert, then redoing the nand* removal. Time was of the essence, so I hope my snap-judgement was sound. My apologies both for the 'oops' and for any other fallout. Warner On Mon, Jun 24, 2019 at 10:50 PM Warner Losh <imp@freebsd.org> wrote: > Author: imp > Date: Tue Jun 25 04:50:09 2019 > New Revision: 349352 > URL: https://svnweb.freebsd.org/changeset/base/349352 > > Log: > Remove NAND and NANDFS support > > NANDFS has been broken for years. Remove it. The NAND drivers that > remain are for ancient parts that are no longer relevant. They are > polled, have terrible performance and just for ancient arm > hardware. NAND parts have evolved significantly from this early work > and little to none of it would be relevant should someone need to > update to support raw nand. This code has been off by default for > years and has violated the vnode protocol leading to panics since it > was committed. > > Numerous posts to arch@ and other locations have found no actual users > for this software. > > Relnotes: Yes > No Objection From: arch@ > Differential Revision: https://reviews.freebsd.org/D20745 > ...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfobKcAjw5Z2u6H7hgZpWTvg5mY1Uz4Ls9MMv98F8LoBWg>