Date: Wed, 24 Sep 2008 09:26:26 +0400 From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com> Cc: rik@freebsd.org, ed@freebsd.org, current@freebsd.org, bug-followup@freebsd.org Subject: Re: kern/127446: [patch] fix race in sys/dev/kbdmux/kbdmux.c Message-ID: <mItlx23gME5dTWNFHx5c9hqhvbU@QMPrI3KwV3l7UDOvbWDm263ry5M> In-Reply-To: <QqKr2VPu8fyQwhEJHQt9Bg/XOKc@K033dsD74Ht1Pqr5uGITGrg6QIg> References: <20080917161633.9E2F717101@shadow.codelabs.ru> <bb4a86c70809170956x36234893he8894a49127b6b6e@mail.gmail.com> <gaH7cu1zt0Bw5e8Q2XfgrlKSRyY@iXA9ZWPrtc2I2BMzBXoToMd7YdQ> <bb4a86c70809171052t5e961675n139b2848e6addd0@mail.gmail.com> <OBTLESaczqaewZBU9qdf0FWZRHE@7/OI9n2WwGs0JPogavdPqCpU9P8> <OukumQcOIGlPdbI1QmdweY8cFsk@IW4pzQfcswHj%2B/3imThIGjvxQdw> <bb4a86c70809190920l29f40e3cja19f6795e19b02b@mail.gmail.com> <byCZZ2L%2BP/vIU5hBTMuURReOshU@p9DJkXKp%2Br2jequ3/WCPe%2BJakGc> <XTJ4IILGIQiL7GkTteNpWNqCP5A@puSb6//93PqXpeckgTOA3gBSgL0> <QqKr2VPu8fyQwhEJHQt9Bg/XOKc@K033dsD74Ht1Pqr5uGITGrg6QIg>
next in thread | previous in thread | raw e-mail | index | archive | help
--Q8BnQc91gJZX4vDc
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Good day.
Tue, Sep 23, 2008 at 02:02:50PM +0400, Eygene Ryabinkin wrote:
> The attached patch was tested on two 7.1-PRERELEASE systems (i386 and
> amd64, both with and without X), on 7.0-STABLE and 7.0-RELEASE-p3 (i386,
> only console, no X) and on rather old 8-CURRENT from Jul 1, syscons.c
> revision 1.459 (amd64 both with and without X). Works fine for me.
>=20
> 8.x needs slightly modified patch due to the naming changes. Also
> attached it. Will try a fresher -CURRENT in some hours: Ed did massive
> changes due to the MPSAFE tty layer, so may be this patch won't be
> needed for the modern 8-CURRENT.
Tested the patches on the 8-CURRENT from yesterday: system is stable, no
side effects both in console and X. As the bonus, I had noticed that
the strange keyboard behaviour that I used to see on my laptop is
disappeared. The effect was the following: after some hours of laptop
inactivity, keyboard input was slow as if a delay of about a second was
introduced between keyboard clicks. I had this only on console, X
worked fine. But now, after 12 hours of laptop inactivity, all works
fine, no delays. May be this is due to the locking changes introduced
by the current patches.
--=20
Eygene
_ ___ _.--. #
\`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
/ ' ` , __.--' # to read the on-line manual =20
)/' _/ \ `-_, / # while single-stepping the kernel.
`-'" `"\_ ,_.-;_.-\_ ', fsc/as #
_.-'_./ {_.' ; / # -- FreeBSD Developers handbook=20
{_.-``-' {_/ #
--Q8BnQc91gJZX4vDc
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)
iEYEARECAAYFAkjZz4IACgkQthUKNsbL7YgRWACgq173xE1Gm/gB2rN+nx+vOJfv
q5kAnRlvnqMvLHd9lcvSE+5ZQB7zHm9y
=zNYs
-----END PGP SIGNATURE-----
--Q8BnQc91gJZX4vDc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?mItlx23gME5dTWNFHx5c9hqhvbU>