Date: Wed, 14 Oct 2009 11:09:20 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/varnish Makefile ports/www/varnish/files pkg-message.in varnishd.in varnishlog.in varnishncsa.in Message-ID: <86tyy2cpfj.fsf@ds4.des.no> In-Reply-To: <4AD55971.3080506@FreeBSD.org> (Doug Barton's message of "Tue, 13 Oct 2009 21:54:09 -0700") References: <200910131851.n9DIpB7P057665@repoman.freebsd.org> <4AD4DE92.3090808@FreeBSD.org> <86iqeietvu.fsf@ds4.des.no> <4AD551E2.3010407@FreeBSD.org> <86tyy2d1si.fsf@ds4.des.no> <4AD55971.3080506@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton <dougb@FreeBSD.org> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > That's a lot of extra code for no perceivable benefit... > The if/else code is essentially the same as yours. Splitting out the > flags that are common between your two options makes the code more > readable. There is also the issue that code in rc.d scripts shouldn't > run unconditionally, but I don't regard that as critical in this case > since you're just setting variables. > > Ultimately it's up to you whether you want to accept the patches or > not. I think they're useful but I am not going to make a stink about it. The *rest* of the patch is very useful. Thank you :) DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86tyy2cpfj.fsf>