Date: Mon, 25 Oct 2004 10:11:56 +0300 From: Ruslan Ermilov <ru@freebsd.org> To: "David O'Brien" <obrien@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libsmb Makefile Message-ID: <20041025071156.GA19910@ip.net.ua> In-Reply-To: <20041025063924.GA86309@dragon.nuxi.com> References: <200410241042.i9OAgFZq085437@repoman.freebsd.org> <20041025063924.GA86309@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
Hi David,
First, apologies for not sending you a HEADS UP. I wanted to do it
but forgot.
On Sun, Oct 24, 2004 at 11:39:24PM -0700, David O'Brien wrote:
> On Sun, Oct 24, 2004 at 10:42:15AM +0000, Ruslan Ermilov wrote:
> > ru 2004-10-24 10:42:15 UTC
> >
> > FreeBSD src repository
> >
> > Modified files:
> > lib/libsmb Makefile
> > Log:
> > -O2 compile isn't quite ready for WARNS=2 yet.
>
> Would you PLEASE let me fix my own problems OR send me a direct email
> that you reverted my commit?? I just spent 30 minutes trying to
> reproduce the tender box errors on two different machines. Which had me
> puzzled since I saw no changes to contrib/smbfs since my commit.
>
Ahem, our friend tinderbox was broken for five days.
> Hum... you know... should I go to Core about you backing out my commit??
> Since we don't officially support a userland at -O2 I wonder what the
> justification of your commit is...
>
Don't we? This is what's now in our make.conf(5) manpage:
: CFLAGS (str) Controls the compiler setting when compiling C code.
: Optimization levels other than -O and -O2 are not sup-
: ported. BDECFLAGS is provided as a set of gcc(1) settings
: suggested by Bruce Evans <bde@FreeBSD.org> for developing
: and testing changes. They can be used, if set, by:
:
: CFLAGS+=${BDECFLAGS}
So it clearly looks to me like -O2 is "officially supported".
It's not about backing out your commit, it's about fixing a build breakage
which was ignored for five days. Again, sorry for not sending you a HEADS
UP, but I needed a tinderbox service up and running as I planned a massive
makefiles commit.
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)
iD8DBQFBfKc8qRfpzJluFF4RAv6TAKCYM9f8gVIJJVOdU1trn+G7eXDNrgCgl1hB
PzkVwyN5KelSKBBpdInIimM=
=65jf
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20041025071156.GA19910>