Date: Tue, 03 Feb 2015 20:34:53 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197234] [UPDATE] lang/execline: update to 2.0.2.0 and take maintainership Message-ID: <bug-197234-13-tCvsfWgqU5@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197234-13@https.bugs.freebsd.org/bugzilla/> References: <bug-197234-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197234 Jan Beich <jbeich@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbeich@FreeBSD.org --- Comment #1 from Jan Beich <jbeich@FreeBSD.org> --- Comment on attachment 152430 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D152430 unified diff to bump lang/execline to current > +LDFLAGS?=3D -s > +STRIPFLAGS?=3D -x Better use ${STRIP} or depend on ! ${PORT_OPTIONS:MDEBUG} and maybe use ven= dor `strip` make target e.g., # STRIP can only be `-s` or empty ALL_TARGET=3D all ${STRIP:S/-s/strip/} > +CC?=3D cc CC is always defined by sys.mk (fmake, bmake) or embedded (gmake). > +WRKSRC=3D ${WRKDIR}/${DISTNAME} No need to redefine the default value. > +USES=3D ${GMAKE} This works only by accident because the path to GNU make isn't an absolute = one. > + cd ${WRKSRC} && CC=3D${CC} ./configure \ > + --prefix=3D${LOCALBASE} \ > + --with-default-path=3D${LOCALBASE}/bin:/usr/bin:/bin \ > + --with-include=3D${LOCALBASE}/include \ > + --with-lib=3D${LOCALBASE}/lib/skalibs \ > + --enable-shared Define HAS_CONFIGURE and populate CONFIGURE_ARGS. This would also fix a case where CC contains spaces e.g., CC =3D distcc ccache gcc > do-build: > + cd ${WRKSRC} && ${GMAKE} Drop custom do-build and maybe define empty ALL_TARGET if `all` doesn't wor= k. > do-install: > + cd ${WRKSRC} && DESTDIR=3D${STAGEDIR} ${GMAKE} install Why not use default do-install and move the following lines under post-inst= all? > @${MKDIR} ${STAGEDIR}${DOCSDIR} > + cd ${WRKSRC} && ${INSTALL_MAN} ${DOCS} ${STAGEDIR}${DOCSDIR} INSTALL_MAN is for manpages only. Other docs should use INSTALL_DATA. > +lib/libexecline.so > +lib/libexecline.so.2 This requires USE_LDCONFIG in Makefile. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197234-13-tCvsfWgqU5>