Date: Mon, 23 Jul 2018 10:27:36 -0700 From: John Baldwin <jhb@FreeBSD.org> To: Conrad Meyer <cem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336439 - in head: share/man/man9 sys/crypto/aesni sys/crypto/armv8 sys/crypto/blake2 sys/crypto/ccp sys/crypto/via sys/dev/cesa sys/dev/cxgbe/crypto sys/dev/hifn sys/dev/safe sys/dev/s... Message-ID: <64ecf6f4-93ff-a8e0-9617-d299d5e52e50@FreeBSD.org> In-Reply-To: <201807180056.w6I0uPb6000705@repo.freebsd.org> References: <201807180056.w6I0uPb6000705@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 7/17/18 5:56 PM, Conrad Meyer wrote: > Author: cem > Date: Wed Jul 18 00:56:25 2018 > New Revision: 336439 > URL: https://svnweb.freebsd.org/changeset/base/336439 > > Log: > OpenCrypto: Convert sessions to opaque handles instead of integers > > Track session objects in the framework, and pass handles between the > framework (OCF), consumers, and drivers. Avoid redundancy and complexity in > individual drivers by allocating session memory in the framework and > providing it to drivers in ::newsession(). > > Session handles are no longer integers with information encoded in various > high bits. Use of the CRYPTO_SESID2FOO() macros should be replaced with the > appropriate crypto_ses2foo() function on the opaque session handle. > > Convert OCF drivers (in particular, cryptosoft, as well as myriad others) to > the opaque handle interface. Discard existing session tracking as much as > possible (quick pass). There may be additional code ripe for deletion. > > Convert OCF consumers (ipsec, geom_eli, krb5, cryptodev) to handle-style > interface. The conversion is largely mechnical. > > The change is documented in crypto.9. > > Inspired by > https://lists.freebsd.org/pipermail/freebsd-arch/2018-January/018835.html . > > No objection from: ae (ipsec portion) > Reported by: jhb And there was much rejoicing. Thanks for doing this Conrad. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?64ecf6f4-93ff-a8e0-9617-d299d5e52e50>