Date: Mon, 9 Mar 2020 09:46:21 -0400 From: Andrew Gallatin <gallatin@cs.duke.edu> To: Andrew Gallatin <gallatin@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358808 - in head/sys: kern net netinet Message-ID: <e5525a78-ce4f-c425-d90b-b45c077fbeb8@cs.duke.edu> In-Reply-To: <202003091344.029Dipuf016764@repo.freebsd.org> References: <202003091344.029Dipuf016764@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-03-09 09:44, Andrew Gallatin wrote: > Author: gallatin > Date: Mon Mar 9 13:44:51 2020 > New Revision: 358808 > URL: https://urldefense.com/v3/__https://svnweb.freebsd.org/changeset/base/358808__;!!OToaGQ!5mmRl2ROq7G4c4x2Xe2uHppYyETGlCRsREj-jHw0ZWcNqt3GhQju3BHBkM_vsrVvkQ$ > > Log: > make lacp's use_numa hashing aware of send tags > > When I did the use_numa support, I missed the fact that there is > a separate hash function for send tag nic selection. So when > use_numa is enabled, ktls offload does not work properly, as it > does not reliably allocate a send tag on the proper egress nic > since different egress nics are selected for send-tag allocation > and packet transmit. To fix this, this change: > > - refectors lacp_select_tx_port_by_hash() and > lacp_select_tx_port() to make lacp_select_tx_port_by_hash() > always called by lacp_select_tx_port() > > - pre-shifts flowids to convert them to hashes when calling lacp_select_tx_port_by_hash() > > - adds a numa_domain field to if_snd_tag_alloc_params > > - plumbs the numa domain into places where we allocate send tags > > In testing with NIC TLS setup on a NUMA machine, I see thousands > of output errors before the change when enabling > kern.ipc.tls.ifnet.permitted=1. After the change, I see no > errors, and I see the NIC sysctl counters showing active TLS > offload sessions. > > Reviewed by: rrs, hselasky, jhb > Sponsored by: Netflix Forgot: Differential: https://reviews.freebsd.org/D23811
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e5525a78-ce4f-c425-d90b-b45c077fbeb8>