Date: Thu, 13 Jan 2000 12:10:30 GMT From: Alan.Judge@indigo.ie To: FreeBSD-gnats-submit@freebsd.org Cc: Alan.Judge@indigo.ie Subject: bin/16098: core dump bug in syslogd, with fix Message-ID: <200001131210.MAA10151@marita.indigo.ie>
next in thread | raw e-mail | index | archive | help
>Number: 16098
>Category: bin
>Synopsis: If you syslogd -vv and get an unknown facility or pri -> dump
>Confidential: no
>Severity: critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Jan 13 04:20:00 PST 2000
>Closed-Date:
>Last-Modified:
>Originator: Alan Judge
>Release: FreeBSD 3.4-STABLE i386
>Organization:
Indigo
>Environment:
syslog server collecting from multiple machines
>Description:
If syslogd, under flags -vv, gets an unknown facility or priority,
you get a core dump. Bug is in both stable and current, I think.
>How-To-Repeat:
>Fix:
cvs diff: Diffing .
Index: syslogd.c
===================================================================
RCS file: /f5/misc/FreeBSD/cvs/src/usr.sbin/syslogd/syslogd.c,v
retrieving revision 1.46.2.4
diff -u -r1.46.2.4 syslogd.c
--- syslogd.c 1999/08/29 15:48:31 1.46.2.4
+++ syslogd.c 2000/01/13 12:01:16
@@ -828,13 +828,13 @@
if (LogFacPri > 1) {
CODE *c;
- for (c = facilitynames; c; c++) {
+ for (c = facilitynames; c->c_name; c++) {
if (c->c_val == fac) {
f_s = c->c_name;
break;
}
}
- for (c = prioritynames; c; c++) {
+ for (c = prioritynames; c->c_name; c++) {
if (c->c_val == pri) {
p_s = c->c_name;
break;
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001131210.MAA10151>