Date: Sat, 21 Feb 2009 17:05:38 -0600 From: Robert Noland <rnoland@FreeBSD.org> To: Anonymous <swell.k@gmail.com> Cc: Ion-Mihai Tetcu <itetcu@FreeBSD.org>, freebsd-ports@freebsd.org Subject: Re: git snapshots, PORTVERSION, PORTEPOCH Message-ID: <1235257538.1278.9.camel@widget.2hip.net> In-Reply-To: <86r61svw0u.fsf@gmail.com> References: <86bpsw2tbf.fsf@gmail.com> <20090221104501.06e778f1@it.buh.tecnik93.com> <86r61svw0u.fsf@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-PVflyK0rhdgJ8ajcX1Nb
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Sat, 2009-02-21 at 15:01 +0300, Anonymous wrote:
> Ion-Mihai Tetcu <itetcu@FreeBSD.org> writes:
>=20
> > On Sat, 21 Feb 2009 09:32:52 +0300
> > Anonymous <swell.k@gmail.com> wrote:
> >
> >> Would it be okay if I use commit hash in PORTVERSION and constantly
> >> bump PORTEPOCH on each update? Are there any such precedents?
> >>=20
> >> %%%
> >> PORTVERSION=3D 0.0.10${SNAPSUFFIX}
> >> PORTEPOCH=3D 1
> >>=20
> >> SNAPSUFFIX=3D .${SNAPTYPE}.${SNAPREV}
> >> SNAPTYPE=3D git
> >> SNAPREV=3D e09f50e
> >> %%%
> >>=20
> >> Where PKGNAME would look like
> >>=20
> >> myport-0.0.10.git.e09f50e,1
> >>=20
> >> I want to keep commit reference in place and refrain from using vague
> >> dates in PORTVERSION because there can be several commits per day. And
> >> for curious users I can include ChangeLog file in distfile generated
> >> from git-log command.
> >
> > No, please don't do this. We use PORTEPOCH when there's no other way.
>=20
> OK. I can include date before commit hash and drop use of PORTEPOCH.
> It would look like
>=20
> SNAPSUFFIX=3D .20090219.e09f50e
>=20
> Any other objections?
I don't think that it is likely that we will be able to make that many
commits to the ports system. I would just use the date as SNAPSUFFIX
and just record the master commit in the Changelog, or maybe in
pkg-message or both.
I really think that more than weekly updates is probably impractical for
the ports system. Maybe twice a week, but even with a rapidly changing
code base, more frequent updates won't really be useful.
robert.
> >
> > Use, like other ports do:
> > PORTVERSION=3D 0.0.10
> > PORTREVISION=3D ${SNAPDATE}
> >
> > I don't see what role SNAPTYPE would have.
>=20
> SNAPTYPE isn't neccessary, just a little convenience.
>=20
> > Since you have the date, you can easily get the git magic string.
>=20
> Dates aren't atomic. That would require precise dates up to seconds and
> still leave place for ambiguity. I opt to not drop git magic string if
> possible else talking to upstream would be a little harder.
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"
--=20
Robert Noland <rnoland@FreeBSD.org>
FreeBSD
--=-PVflyK0rhdgJ8ajcX1Nb
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (FreeBSD)
iEYEABECAAYFAkmgiMIACgkQM4TrQ4qfRONjXgCaAzDTMbOp4j+U5abxl3fbIyjp
fF8An2ZyCPyg2iladwIWqNGvJAHoQjMI
=h1w3
-----END PGP SIGNATURE-----
--=-PVflyK0rhdgJ8ajcX1Nb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1235257538.1278.9.camel>