Date: Tue, 17 Feb 1998 15:10:42 -0800 From: Mike Smith <mike@smith.net.au> To: Max Euston <meuston@jmrodgers.com> Cc: "'Tim Vanderhoek'" <hoek@hwcn.org>, "'FreeBSD Hackers'" <freebsd-hackers@FreeBSD.ORG> Subject: Re: Modifications to more(1) Message-ID: <199802172310.PAA03414@dingo.cdrom.com> In-Reply-To: Your message of "Tue, 17 Feb 1998 12:22:11 EST." <01BD3B9E.ACEB1140.meuston@jmrodgers.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> > > this leads me to believe that this option is out-of-date (also > > > it does not follow the standard). My question is: should I fix > > > the -# option or remove it (my vote is to remove it - see > > > below). > > > > How long has it been broken? If it was broken in the last > > release or two, then probably no-one has noticed and it should > > just disappear. > > > Please excuse my ignorance re: CVS, but I have not used it before (used > other RCSs, but syntax/usage is different). I will learn more as I start > to work with it. > > I don't know how to check this (i.e. check specific versions of ONE file > only - without installing a whole set of files from a distribution). You can query the FreeBSD CVS repository at http://www.freebsd.org/cgi/cvsweb.cgi > I am running 2.2.5-release and just started to install & build CVSup when > my swap space filled during the build - I will have to reconfigure this (or > download the pre-built binary; not my first choice). The prebuilt binary is the only sensible way to go with CVSup unless you are a total masochist, or are soak-testing a new, extremely powerful system. > Finally (some very basic questions, but I don't have the answers - sorry): > > If I make changes to existing source code that does NOT follow current > FreeBSD style (indents, header files, etc...), is it proper to maintain the > style of the existing code or should I use the newer format? (e.g. should I > "#include <string.h>" or "extern char *strcat()")? You should maintain the style of the file you are working on. If you want to perform a major cleanup of the code, then that's something best done in a separate set of changes. > Should I change the 'sccsid[]' date and/or version number? No. These are artifacts of a previous revision control system, and are generally left there so that people can trace the original source of the files. Also, gratuitously removing them would just add more (unuseful) bulk to the CVS repository. Just ignore them. -- \\ Sometimes you're ahead, \\ Mike Smith \\ sometimes you're behind. \\ mike@smith.net.au \\ The race is long, and in the \\ msmith@freebsd.org \\ end it's only with yourself. \\ msmith@cdrom.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199802172310.PAA03414>