Date: Tue, 26 Nov 2024 20:36:38 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 282733] [NEW PORT] textproc/dmenu-translate: Quick text translation with dmenu Message-ID: <bug-282733-7788-kTOOTmRn0I@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-282733-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-282733-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D282733 --- Comment #5 from Robert Clausecker <fuz@FreeBSD.org> --- Thanks. If you can't use base sed, using GNU sed should be fine. As for your current patch, it looks better. Some things that need to be fi= xed: - do not invent a version number when upstream doesn't have one, instead follow the example given in =C2=A7 5.4.3 "USE_GITHUB" Example 17. - use the full git hash for GH_TAGNAME so it's unambiguous in any case - prefer DISTVERSION over PORTVERSION if possible - please check the grammar of your option descriptions; perhaps something = like this would work? WAYLAND_DESC=3D depend on x11/wmenu and x11/wl-clipboard for use with W= ayland X11_DESC=3D depend on x11/dmenu and x11/xclip for use with X11 - our mktemp does not support --tempdir. Please check the manual. Perhaps you want "mktemp -d dmenu-translate.XXXXXX' Please check and resubmit if possible. I'm sorry for not catching these is= sues earlier. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-282733-7788-kTOOTmRn0I>