Date: Wed, 8 Mar 2006 16:05:54 +0100 (CET) From: Harti Brandt <hartmut.brandt@dlr.de> To: Daniel Eischen <deischen@freebsd.org> Cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>, current@freebsd.org Subject: Re: When will bsnmp stop breaking -current builds Message-ID: <20060308154805.D10582@beagle.kn.op.dlr.de> In-Reply-To: <Pine.GSO.4.43.0603080938500.13516-100000@sea.ntplx.net> References: <Pine.GSO.4.43.0603080938500.13516-100000@sea.ntplx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-192900866-1141829788=:10582 Content-Type: TEXT/PLAIN; CHARSET=koi8-r Content-Transfer-Encoding: QUOTED-PRINTABLE Content-ID: <20060308155647.Y10582@beagle.kn.op.dlr.de> On Wed, 8 Mar 2006, Daniel Eischen wrote: DE>On Wed, 8 Mar 2006, Dag-Erling [iso-8859-1] Sm=F8rgrav wrote: DE> DE>> Harti Brandt <hartmut.brandt@dlr.de> writes: DE>> > I checked that gensnmptree does not generated these useless DE>> > references since at least early 2001. DE>> DE>> The machine where I had this problem was running a two-week old DE>> -CURRENT. DE> DE>Same here, give or take a few days. This seems to be exact the time when usr.sbin/bsnmp was detached from=20 world because of my misimport. This was from 2/14/2006 until 2/27/2006. I wonder how this happens... Ok. I think I got it. In Rev. 1.1.1.9 of gensnmptree.c I fixed a bug that= =20 was discovered by jasone: the flag field of struct node was not=20 initialized to 0. This field contains the flags FL_GET and FL_SET. If both= =20 of them are zero, nothing is emitted for that node - this is what should=20 happen to the nodes that reference the op_*dummy() functions. Even with=20 this bug the code happend to work, because this location was 0 with=20 phkmalloc. With the new malloc code the flag field contains obviously a=20 non-zero value. So if you have an old gensnmptree (which may happen=20 because the build of it was detached from world for some time) and a new=20 malloc, you end up getting these references. But for this to happen the build process also must use the installed=20 gensnmptree (because the newly compiled one would not have this bug). Can one of you verify that the new gensnmptree does the right thing?: cd /usr/src/usr.sbin/bsnmpd/gensnmptree make clean make cd /usr/src/contrib/bsnmp/snmpd =2E../gensnmptree <tree.def grep dymmy tree.c rm tree.c tree.h Replace ... by the path to the fresh gensnmptree. I think the build process should use the new gensnmptree. harti --0-192900866-1141829788=:10582--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060308154805.D10582>