Date: Thu, 3 Mar 2011 17:04:57 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org Subject: svn commit: r219234 - stable/8/sys/kern Message-ID: <201103031704.p23H4vog053908@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jhb Date: Thu Mar 3 17:04:57 2011 New Revision: 219234 URL: http://svn.freebsd.org/changeset/base/219234 Log: MFC 200761,218272: Always assert that the turnstile chain lock is held in turnstile_wait() and remove a duplicate hash lookup. Modified: stable/8/sys/kern/subr_turnstile.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/amd64/include/xen/ (props changed) stable/8/sys/cddl/contrib/opensolaris/ (props changed) stable/8/sys/contrib/dev/acpica/ (props changed) stable/8/sys/contrib/pf/ (props changed) Modified: stable/8/sys/kern/subr_turnstile.c ============================================================================== --- stable/8/sys/kern/subr_turnstile.c Thu Mar 3 17:04:45 2011 (r219233) +++ stable/8/sys/kern/subr_turnstile.c Thu Mar 3 17:04:57 2011 (r219234) @@ -685,8 +685,8 @@ turnstile_wait(struct turnstile *ts, str * turnstile already in use by this lock. */ tc = TC_LOOKUP(ts->ts_lockobj); - if (ts == td->td_turnstile) { mtx_assert(&tc->tc_lock, MA_OWNED); + if (ts == td->td_turnstile) { #ifdef TURNSTILE_PROFILING tc->tc_depth++; if (tc->tc_depth > tc->tc_max_depth) { @@ -695,7 +695,6 @@ turnstile_wait(struct turnstile *ts, str turnstile_max_depth = tc->tc_max_depth; } #endif - tc = TC_LOOKUP(ts->ts_lockobj); LIST_INSERT_HEAD(&tc->tc_turnstiles, ts, ts_hash); KASSERT(TAILQ_EMPTY(&ts->ts_pending), ("thread's turnstile has pending threads"));
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201103031704.p23H4vog053908>