Date: Fri, 1 Apr 2011 14:08:07 -0400 From: Andrew Duane <aduane@juniper.net> To: "mips@freebsd.org" <mips@freebsd.org> Subject: Blatant simple bug in Cavium SDK USB code? Message-ID: <AC6674AB7BC78549BB231821ABF7A9AEB52F1950C7@EMBX01-WF.jnpr.net> In-Reply-To: <AC6674AB7BC78549BB231821ABF7A9AEB52F1950C5@EMBX01-WF.jnpr.net> References: <AC6674AB7BC78549BB231821ABF7A9AEB52F1950C5@EMBX01-WF.jnpr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
In the routine cvmx_usb_initialize in sys/contrib/octeon-sdk/cvmx-usb.c, I'm pretty sure there's a silly little bug that really BADLY breaks the USB driver for some of us.
Near the top, after it finds board type and sets the clock type, as part of the structure initialization, there is:
memset(usb, 0, sizeof(usb));
Tell me that is not supposed to be:
memset(usb, 0, sizeof(*usb));
The existing code only zeros 4/8 bytes, instead of the 23KB of the structure.
--
Andrew Duane Juniper Networks
978-589-0551 10 Technology Park Dr
aduane@juniper.net Westford, MA 01886-3418
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AC6674AB7BC78549BB231821ABF7A9AEB52F1950C7>