Date: Tue, 23 Aug 2011 09:13:26 +0200 From: =?ISO-8859-2?Q?Pawe=B3_P=EAkala?= <pawel@freebsd.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/polish/kadu Makefile distinfo pkg-descr pkg-plist ports/polish/kadu/files patch-kadu-core__CMakeLists.txt patch-kadu-core_gadu_resolver.cpp patch-modules__docking__CMakeLists.txt patch-modules__idle__CMakeLists.txt patch-modules__kde_notify__CMakeLists.txt patch-modules__screenshot__CMakeLists.txt patch-modules__sound__CMakeLists.txt ... Message-ID: <20110823091326.00002064@unknown> In-Reply-To: <20110823020838.GA96726@FreeBSD.org> References: <201108221821.p7MILBln038468@repoman.freebsd.org> <20110823020838.GA96726@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Dnia , o godz.=20
Alexey Dokuchaev <danfe@FreeBSD.org> napisa=B3(a):
> Still some issues with this port:
Thanks for your suggestions, I`m new here so they will help me improve
my contributions. Firstly I want to say that this is situation where I
was taking over maintaniership so there were two people (me and
former maintainer) working on update so different "styles" got mixed
etc.
> - First part of the makefile (delarative one) is badly indented;
> indentation should be reduced my one tabstop
Sometimes more indentation help readability, in this case you are right
it's too many ;-) When submitting updates to other people's ports my
rule is always to stick to their style of indentation, it may look
messy to me but may work for maintainer.
> - Bad spelling of Qt toolkit in COMMENT (it looks like port is
> QuickTime based now); also, " / " does not look too good, simple
> "and" would look better
Good catch. Project description is now "Internet Communicator" as they
gained ability to connect Jabber network so I can use this.
=20
> %%%
> LIB_DEPENDS=3D enchant.1:${PORTSDIR}/textproc/enchant \
> gadu.3:${PORTSDIR}/polish/libgadu \
> + idn:${PORTSDIR}/dns/libidn \
> qca.2:${PORTSDIR}/devel/qca \
> sndfile.1:${PORTSDIR}/audio/libsndfile
> %%%
>=20
> Missing shlib version (notice that other libs have it). While it
> technically not required, it's nice to have to be able to grep for
> when buming port revision of library consumer ports to chase shlib
> version bumps.
While I am with Doug at this one things could be more consistent - if
there are shlib versions they should be on all dependencies.
According to upstream version 0.10.0 will be released soon, I will
incorporate all mentioned things in that update.
Pawe=B3
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110823091326.00002064>