Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Apr 2017 14:25:01 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r317436 - head/lib/libc/gen
Message-ID:  <201704261425.v3QEP1P8005121@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Wed Apr 26 14:25:01 2017
New Revision: 317436
URL: https://svnweb.freebsd.org/changeset/base/317436

Log:
  getpagesize(3) cannot fail.
  
  The sysctl(HW_PAGESIZE) call cannot fail on FreeBSD kernels at least.
  And even if it failed for some improbable reason, PAGE_SIZE is a safe
  value to return.
  
  Discussed with:	jilles
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week

Modified:
  head/lib/libc/gen/getpagesize.c

Modified: head/lib/libc/gen/getpagesize.c
==============================================================================
--- head/lib/libc/gen/getpagesize.c	Wed Apr 26 06:20:58 2017	(r317435)
+++ head/lib/libc/gen/getpagesize.c	Wed Apr 26 14:25:01 2017	(r317436)
@@ -69,7 +69,7 @@ getpagesize(void)
 	mib[1] = HW_PAGESIZE;
 	size = sizeof value;
 	if (sysctl(mib, nitems(mib), &value, &size, NULL, 0) == -1)
-		return (-1);
+		return (PAGE_SIZE);
 
 	return (value);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704261425.v3QEP1P8005121>