Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Apr 2026 02:56:13 +0000
From:      Gleb Smirnoff <glebius@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 2bd2f267f344 - main - kgss: remove unnecessary CURVNET_SET() and kgss_gssd_handle checks
Message-ID:  <69ec2d4d.37375.2cfce26f@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by glebius:

URL: https://cgit.FreeBSD.org/src/commit/?id=2bd2f267f344c51c66fc18d963df8cec78db34c1

commit 2bd2f267f344c51c66fc18d963df8cec78db34c1
Author:     Gleb Smirnoff <glebius@FreeBSD.org>
AuthorDate: 2026-04-25 02:55:50 +0000
Commit:     Gleb Smirnoff <glebius@FreeBSD.org>
CommitDate: 2026-04-25 02:55:50 +0000

    kgss: remove unnecessary CURVNET_SET() and kgss_gssd_handle checks
    
    These RPC methods correctly acquire the kgss_gssd_handle later with call
    to kgss_gssd_client().
    
    Reviewed by:            rmacklem
    Differential Revision:  https://reviews.freebsd.org/D56561
---
 sys/kgssapi/gss_delete_sec_context.c | 8 --------
 sys/kgssapi/gss_release_cred.c       | 8 --------
 sys/kgssapi/gss_release_name.c       | 8 --------
 3 files changed, 24 deletions(-)

diff --git a/sys/kgssapi/gss_delete_sec_context.c b/sys/kgssapi/gss_delete_sec_context.c
index c435e6193b0f..b5a985215b6b 100644
--- a/sys/kgssapi/gss_delete_sec_context.c
+++ b/sys/kgssapi/gss_delete_sec_context.c
@@ -28,7 +28,6 @@
  */
 
 #include <sys/param.h>
-#include <sys/jail.h>
 #include <sys/kernel.h>
 #include <sys/kobj.h>
 #include <sys/lock.h>
@@ -52,13 +51,6 @@ gss_delete_sec_context(OM_uint32 *minor_status, gss_ctx_id_t *context_handle,
 
 	*minor_status = 0;
 
-	CURVNET_SET_QUIET(TD_TO_VNET(curthread));
-	if (!VNET(kgss_gssd_handle)) {
-		CURVNET_RESTORE();
-		return (GSS_S_FAILURE);
-	}
-	CURVNET_RESTORE();
-
 	if (*context_handle) {
 		ctx = *context_handle;
 
diff --git a/sys/kgssapi/gss_release_cred.c b/sys/kgssapi/gss_release_cred.c
index 191eca0904c6..f46c3ec5ac06 100644
--- a/sys/kgssapi/gss_release_cred.c
+++ b/sys/kgssapi/gss_release_cred.c
@@ -28,7 +28,6 @@
  */
 
 #include <sys/param.h>
-#include <sys/jail.h>
 #include <sys/kernel.h>
 #include <sys/kobj.h>
 #include <sys/lock.h>
@@ -50,13 +49,6 @@ gss_release_cred(OM_uint32 *minor_status, gss_cred_id_t *cred_handle)
 
 	*minor_status = 0;
 
-	CURVNET_SET_QUIET(TD_TO_VNET(curthread));
-	if (!VNET(kgss_gssd_handle)) {
-		CURVNET_RESTORE();
-		return (GSS_S_FAILURE);
-	}
-	CURVNET_RESTORE();
-
 	if (*cred_handle) {
 		args.cred = (*cred_handle)->handle;
 
diff --git a/sys/kgssapi/gss_release_name.c b/sys/kgssapi/gss_release_name.c
index d5d86fb107ff..76c77868ed9e 100644
--- a/sys/kgssapi/gss_release_name.c
+++ b/sys/kgssapi/gss_release_name.c
@@ -28,7 +28,6 @@
  */
 
 #include <sys/param.h>
-#include <sys/jail.h>
 #include <sys/kernel.h>
 #include <sys/kobj.h>
 #include <sys/lock.h>
@@ -51,13 +50,6 @@ gss_release_name(OM_uint32 *minor_status, gss_name_t *input_name)
 
 	*minor_status = 0;
 
-	CURVNET_SET_QUIET(TD_TO_VNET(curthread));
-	if (!VNET(kgss_gssd_handle)) {
-		CURVNET_RESTORE();
-		return (GSS_S_FAILURE);
-	}
-	CURVNET_RESTORE();
-
 	if (*input_name) {
 		name = *input_name;
 		args.input_name = name->handle;


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?69ec2d4d.37375.2cfce26f>