Date: Mon, 20 Dec 2021 08:32:10 +0100 From: Wojciech Macek <wma@semihalf.com> To: Kyle Evans <kevans@freebsd.org>, Marcin Wojtas <mw@freebsd.org> Cc: Wojciech Macek <wma@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 4f741801d860 - main - t_setrlimit: Adjust resource limit to 20M Message-ID: <CANsEV8erfPbgTVNGqfmfS9Rv6H_PdwMd2ubXBvJfQc2=U4yzTQ@mail.gmail.com> In-Reply-To: <CACNAnaHMg5WpXQT_TEVPq3STmtgjwL1Mhzc3c02zvS1UR-Epmg@mail.gmail.com> References: <202112200529.1BK5T0np047358@gitrepo.freebsd.org> <CACNAnaHMg5WpXQT_TEVPq3STmtgjwL1Mhzc3c02zvS1UR-Epmg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Hi Kyle, Thanks for the comment, I thought this one is discussed but apparently I was mistaken. Adding Marcin to handle this on our side. I'm fine with reverting it anyway or do whatever you decide. Regards, Wojtek pon., 20 gru 2021 o 07:51 Kyle Evans <kevans@freebsd.org> napisał(a): > On Sun, Dec 19, 2021 at 11:29 PM Wojciech Macek <wma@freebsd.org> wrote: > > > > The branch main has been updated by wma: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=4f741801d86089a1c5d631ba1e0f1421cdcf7a7e > > > > commit 4f741801d86089a1c5d631ba1e0f1421cdcf7a7e > > Author: Dawid Gorecki <dgr@semihalf.com> > > AuthorDate: 2021-12-20 05:27:12 +0000 > > Commit: Wojciech Macek <wma@FreeBSD.org> > > CommitDate: 2021-12-20 05:28:20 +0000 > > > > t_setrlimit: Adjust resource limit to 20M > > > > With ASLR enabled by default, RLIMIT_STACK test fails due to the fact > > that default stack gap can be as big as 15M. Because of that the > > resource limit of 4M results in test program receiving SIGSEGV > > immediately after exiting the setrlimit syscall. Since the idea of > this > > test is to check if rlim_cur does not extend past rlim_max, adjusting > > the resource limit to 20M should not invalidate the test results. > > > > I can't seem to find the PR at the moment, but isn't this exactly the > kind of thing markj@ talked about trying to avoid elsewhere? It seems > like this probably should've been involved in the discussion rather > than hacked around independently. > > Thanks, > > Kyle Evans > [-- Attachment #2 --] <div dir="ltr">Hi Kyle,<div><br></div><div>Thanks for the comment, I thought this one is discussed but apparently I was mistaken.</div><div>Adding Marcin to handle this on our side. I'm fine with reverting it anyway or do whatever you decide.</div><div><br></div><div>Regards,</div><div>Wojtek</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">pon., 20 gru 2021 o 07:51 Kyle Evans <<a href="mailto:kevans@freebsd.org">kevans@freebsd.org</a>> napisał(a):<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sun, Dec 19, 2021 at 11:29 PM Wojciech Macek <<a href="mailto:wma@freebsd.org" target="_blank">wma@freebsd.org</a>> wrote:<br> ><br> > The branch main has been updated by wma:<br> ><br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=4f741801d86089a1c5d631ba1e0f1421cdcf7a7e" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=4f741801d86089a1c5d631ba1e0f1421cdcf7a7e</a><br>; ><br> > commit 4f741801d86089a1c5d631ba1e0f1421cdcf7a7e<br> > Author: Dawid Gorecki <<a href="mailto:dgr@semihalf.com" target="_blank">dgr@semihalf.com</a>><br> > AuthorDate: 2021-12-20 05:27:12 +0000<br> > Commit: Wojciech Macek <wma@FreeBSD.org><br> > CommitDate: 2021-12-20 05:28:20 +0000<br> ><br> > t_setrlimit: Adjust resource limit to 20M<br> ><br> > With ASLR enabled by default, RLIMIT_STACK test fails due to the fact<br> > that default stack gap can be as big as 15M. Because of that the<br> > resource limit of 4M results in test program receiving SIGSEGV<br> > immediately after exiting the setrlimit syscall. Since the idea of this<br> > test is to check if rlim_cur does not extend past rlim_max, adjusting<br> > the resource limit to 20M should not invalidate the test results.<br> ><br> <br> I can't seem to find the PR at the moment, but isn't this exactly the<br> kind of thing markj@ talked about trying to avoid elsewhere? It seems<br> like this probably should've been involved in the discussion rather<br> than hacked around independently.<br> <br> Thanks,<br> <br> Kyle Evans<br> </blockquote></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANsEV8erfPbgTVNGqfmfS9Rv6H_PdwMd2ubXBvJfQc2=U4yzTQ>