Date: Sun, 19 Jan 2014 16:37:58 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r260883 - head/sys/geom/multipath Message-ID: <201401191637.s0JGbwOO096494@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mav Date: Sun Jan 19 16:37:57 2014 New Revision: 260883 URL: http://svnweb.freebsd.org/changeset/base/260883 Log: Removed unneeded and dangerous assignment. It would probably cause NULL refererence panic if compiler not optimize it out. Found with: Clang static analyzer MFC after: 2 weeks Modified: head/sys/geom/multipath/g_multipath.c Modified: head/sys/geom/multipath/g_multipath.c ============================================================================== --- head/sys/geom/multipath/g_multipath.c Sun Jan 19 16:07:27 2014 (r260882) +++ head/sys/geom/multipath/g_multipath.c Sun Jan 19 16:37:57 2014 (r260883) @@ -1089,7 +1089,6 @@ g_multipath_ctl_create(struct gctl_req * gctl_error(req, "Device %s already exist", mpname); return; } - sc = gp->softc; memset(&md, 0, sizeof(md)); strlcpy(md.md_magic, G_MULTIPATH_MAGIC, sizeof(md.md_magic));
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401191637.s0JGbwOO096494>