Date: Wed, 05 Feb 2003 18:09:10 +0200 From: Maxim Sobolev <sobomax@portaone.com> To: "Simon 'corecode' Schubert" <corecode@corecode.ath.cx> Cc: Maxim Sobolev <sobomax@freebsd.org>, ports@freebsd.org, portmgr@freebsd.org Subject: Re: USE_GETOPT patch available Message-ID: <3E413726.7AF3B256@portaone.com> References: <20030205011921.24c642cb.corecode@corecode.ath.cx> <20030205010005.GA35933@vega.vega.com> <20030205024524.2edc919c.corecode@corecode.ath.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
Simon 'corecode' Schubert wrote:
>
> Lately Maxim Sobolev told:
>
> > I think that you had overcomplicated things a bit, with all those
> > automagick. Something like the following would be more than enough:
>
> [code sets GNUGETOPT_{CFLAGS,LIBS}]
>
> but how does configure/make get these?
>
> ${SETENV} can't accumulate variables (like env CFLAGS=foo CFLAGS=bar)
>
> okay, one simple fix could be just adding LDFLAGS to the environment of
> configure (not CONFIGURE_ENV) and then preventing ports to set
> CFLAGS/LDFLAGS. does that seem reasonable?
foo/Makefile:
USE_GNUGETOPT=yes
CONFIGURE_ENV=CPPFLAGS="${GNUGETOPT_CFLAGS} -ISOME -DOTHER -FLAGS"
LIBS="${GNUGETOPT_LIBS}"
The reason why I think that automatic addition into CONFIGURE_ENV is
Bad Thing[tm] is because user might have other options in
CPPFLAGS/LIBS, in that case your patch will wanish them.
-Maxim
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3E413726.7AF3B256>