Date: Sun, 21 Apr 2013 13:11:09 +0400 From: "Andrey V. Elsukov" <ae@FreeBSD.org> To: Steven Hartland <killing@multiplay.co.uk> Cc: Joshua Isom <jrisom@gmail.com>, freebsd-current@freebsd.org Subject: Re: Booting an alternative kernel from loader prompt fails the first time only Message-ID: <5173AD2D.6030008@FreeBSD.org> In-Reply-To: <A09B749B8A08428BB9BE54588FA64641@multiplay.co.uk> References: <625362A8116D4B43AF4912773F478CB9@multiplay.co.uk> <5172C699.8020708@smeets.im> <5172CF44.1050309@gwdg.de> <201304201741.r3KHfrJe001805@pozo.com> <517327C5.5050305@gmail.com> <A09B749B8A08428BB9BE54588FA64641@multiplay.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21.04.2013 04:36, Steven Hartland wrote: > This fails and trips the "Restart from the beginning" case which contains: > last_file_format = i = 0; > fp = NULL; > continue; > > So "i" gets set to 0 but the loop then increments it to 1 before running > the next iteration, so its impossible to use first handler in the retry > case; which I suspect is the kernel loader. > > This also explains why the second call to boot works as last_file_format > is now 0 due to the previous failure. > > If this is the issue the attached patch should fix it. I can't test it > ATM as my current box is at the office and doesn't have remote KVM, so > I need to be in front of it. > > If anyone can confirm this attached patch fixes the problem then I'll get > it committed, otherwise I'll test on Monday. Hi, yes, you are right. I just committed this with r249719. Thanks. -- WBR, Andrey V. Elsukov
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5173AD2D.6030008>