Date: Mon, 30 Jun 2014 14:47:21 -0400 From: John Baldwin <jhb@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r268055 - head/sys/sys Message-ID: <201406301447.21620.jhb@freebsd.org> In-Reply-To: <53B1AFDE.30104@selasky.org> References: <201406301811.s5UIBMxh036571@svn.freebsd.org> <201406301437.08687.jhb@freebsd.org> <53B1AFDE.30104@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Monday, June 30, 2014 2:43:42 pm Hans Petter Selasky wrote: > On 06/30/14 20:37, John Baldwin wrote: > > Reindenting the whitespace made this diff harder to read. Why hasn't this > > been a problem before on powerpc64? > > Hi, > > This has not been a problem before, because producers of DATA_SET()'s > were using syntax along these lines: > > static int test2; > static int test3; > > DATA_SET(test, test2); > DATA_SET(test, test3); > > Now if you change this simple code to: > > static int test2; > int test3; > > DATA_SET(test, test2); > DATA_SET(test, test3); > > It breaks on powerpc64. Should be very easy to reproduce. > > The problem with SYSCTL's is that some are global and some are not. > Before an indirect pointer was hiding this problem from appearing. > > Do you see? Or do you want me to explain more. Ahh, ok. Seems odd that this sort of thing would be ppc64-specific however. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201406301447.21620.jhb>