Date: Fri, 15 Mar 2013 14:13:15 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Andre Oppermann <andre@freebsd.org> Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r248269 - user/andre/tcp-ao/sys/netinet Message-ID: <20130315101315.GJ48089@FreeBSD.org> In-Reply-To: <5141FF11.3000504@freebsd.org> References: <201303141627.r2EGR2gA033139@svn.freebsd.org> <20130314162933.GG48089@FreeBSD.org> <5141FF11.3000504@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 14, 2013 at 05:47:13PM +0100, Andre Oppermann wrote: A> On 14.03.2013 17:29, Gleb Smirnoff wrote: A> > Andre, A> > A> > On Thu, Mar 14, 2013 at 04:27:02PM +0000, Andre Oppermann wrote: A> > A> Author: andre A> > A> Date: Thu Mar 14 16:27:01 2013 A> > A> New Revision: 248269 A> > A> URL: http://svnweb.freebsd.org/changeset/base/248269 A> > A> A> > A> Log: A> > A> Add IPv6 pseudo header for use in checksum calculations. A> > A> > Why obsoleted u_intXX_t instead of uintXX_t in new code? A> A> Legacy style of surrounding code. What's our policy there? I tend to keep it A> the same. Quoting style(9): The project is slowly moving to use the ISO/IEC 9899:1999 (``ISO C99'') unsigned integer identifiers of the form uintXX_t in preference to the older BSD-style integer identifiers of the form u_intXX_t. New code should use the former, and old code should be converted to the new form if other major work is being done in that area and there is no overriding reason to prefer the older BSD-style. Like white-space commits, care should be taken in making uintXX_t only commits. -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130315101315.GJ48089>