Date: Sun, 25 Feb 2024 18:53:24 +0100 From: Michael Grimm <trashcan@ellael.org> To: Moin Rahman <bofh@freebsd.org> Cc: FreeBSD Mailing List <freebsd-ports@freebsd.org> Subject: Re: dns/knot-resolver security update to 5.7.1 Message-ID: <DF5CC702-80F7-4EC2-AAF0-7141FD69E7E3@ellael.org> In-Reply-To: <A733B3C9-F916-403A-9312-FD3F359D0B6B@freebsd.org> References: <14DA84EE-3CC0-454E-967A-CBFF40C06ABD@ellael.org> <232E3D69-782B-49A7-9B82-AA59765DA98B@freebsd.org> <689E4249-F841-4B39-94E0-F2725518BFA0@ellael.org> <A733B3C9-F916-403A-9312-FD3F359D0B6B@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Moin Rahman <bofh@freebsd.org> wrote: >> On Feb 25, 2024, at 6:15 PM, Michael Grimm <trashcan@ellael.org> = wrote: >> P.S. Please forgive my lack in experience with PRs ;-) >> Please let me know, what to correct if neccessary >=20 > Well as a starter: > 1. You do not need PORTREVISION when you already bumping PORTVERSION = or updating versions. I will fix it while committing. > 2. Follow this process: > a. Initially create the PR with synopsis and description. > b. Create git-formatted patch > c. Read this section of the documentation: > = https://docs.freebsd.org/en/articles/committers-guide/#git-mini-daily-use > d. Specially the git hook part and try to use the hook from here: > https://cgit.freebsd.org/ports/tree/.hooks/prepare-commit-msg > e. Now make a commit to your local branch with the description, PR = etc whatever is relevant. > f. Create a git formatted patch and attach it to the PR. >=20 > While people think this is difficult workflow it actually makes our = life easier as we also have to do the same and also helps us attributing = external developers more easily. Many thanks, I will follow your advice in the future! Especially about d) (hook) I have been totally unaware. Regards, Michael=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?DF5CC702-80F7-4EC2-AAF0-7141FD69E7E3>