Date: Tue, 1 Sep 2020 15:34:55 +0200 From: Michal Meloun <meloun.michal@gmail.com> To: Emmanuel Vadot <manu@bidouilliste.com> Cc: Niclas Zeising <zeising@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364737 - head/sys/dev/drm2 Message-ID: <6ce33c1a-a268-dbaa-a434-e4769827b168@gmail.com> In-Reply-To: <20200901151635.91c121acb2bf58e9282aa6ae@bidouilliste.com> References: <202008242253.07OMrNO2016612@repo.freebsd.org> <790db2ea-0877-671e-e48f-ec6da42c7437@gmail.com> <20200901151635.91c121acb2bf58e9282aa6ae@bidouilliste.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01.09.2020 15:16, Emmanuel Vadot wrote: > On Tue, 1 Sep 2020 15:13:53 +0200 > Michal Meloun <meloun.michal@gmail.com> wrote: > >> >> >> On 25.08.2020 0:53, Niclas Zeising wrote: >>> Author: zeising (doc,ports committer) >>> Date: Mon Aug 24 22:53:23 2020 >>> New Revision: 364737 >>> URL: https://svnweb.freebsd.org/changeset/base/364737 >>> >>> Log: >>> drm2: Update deprecation message >>> >>> Update the deprecation message in the drm2 (aka legacy drm) drivers to point >>> towards the graphics/drm-kmod ports for all architectures, not just amd64. >> Only known user of drm2 is arm/tegra124 based boards. How >> graphics/drm-kmod can help for these? >> Or be more specific - drm2 allows me to hot-plug monitor to tegra based >> board an use 2 scaled overlay planes (which is exactly whats I want for >> my application). Which alternative can you offer me? >> Btw, as you can see, the maintenance cost of drm2 is close to zero and >> the dev/drm2 code does not inherit with any of the major architectures. >> >> Michal > > I think that the goal was only to mfc this to warn users before 12.2 > is branched, maybe a direct commit to 12 would have been better. > My main concern is #ifdef removal (thus expanding the removal message also on QARM). I understand that drm2 code is very old, but it works, is used, and have very minimal impact on other architectures or rest of kernel. Within these conditions, I don't see single reason to remove (on ARM) drm2 code in 13. >> >>> drm-kmod has support for more architectures these days, and the >>> graphics/drm-legacy-kmod port is being deprecated. >> >>> >>> Approved by: imp >>> MFC after: 1 week >>> Differential Revision: https://reviews.freebsd.org/D26174 >>> >>> Modified: >>> head/sys/dev/drm2/drm_os_freebsd.h >>> >>> Modified: head/sys/dev/drm2/drm_os_freebsd.h >>> ============================================================================== >>> --- head/sys/dev/drm2/drm_os_freebsd.h Mon Aug 24 22:48:19 2020 (r364736) >>> +++ head/sys/dev/drm2/drm_os_freebsd.h Mon Aug 24 22:53:23 2020 (r364737) >>> @@ -154,16 +154,12 @@ typedef void irqreturn_t; >>> *(volatile u_int64_t *)(((vm_offset_t)(map)->handle) + \ >>> (vm_offset_t)(offset)) = htole64(val) >>> >>> -#ifdef amd64 >>> #define DRM_PORT "graphics/drm-kmod" >>> -#else >>> -#define DRM_PORT "graphics/drm-legacy-kmod" >>> -#endif >>> >>> #define DRM_OBSOLETE(dev) \ >>> do { \ >>> device_printf(dev, "=======================================================\n"); \ >>> - device_printf(dev, "This code is obsolete abandonware. Install the " DRM_PORT " pkg\n"); \ >>> + device_printf(dev, "This code is deprecated. Install the " DRM_PORT " pkg\n"); \ >>> device_printf(dev, "=======================================================\n"); \ >>> gone_in_dev(dev, 13, "drm2 drivers"); \ >>> } while (0) >>> > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6ce33c1a-a268-dbaa-a434-e4769827b168>