Date: Sat, 14 Dec 2019 11:47:49 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Jan Beich <jbeich@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r520074 - head/ftp/curl Message-ID: <67545a34-c13d-523f-ebe9-111a86117bd7@FreeBSD.org> In-Reply-To: <d0cr-d9ub-wny@FreeBSD.org> References: <201912140013.xBE0DB77036746@repo.freebsd.org> <d0cr-d9ub-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/12/2019 11:33 am, Jan Beich wrote:
> Kubilay Kocak <koobs@FreeBSD.org> writes:
>
>> -OPTIONS_DEFAULT= ALTSVC CA_BUNDLE COOKIES GSSAPI_${${SSL_DEFAULT} == base :?BASE :NONE} DICT FTP GOPHER HTTP HTTP2 IMAP OPENSSL POP3 PROXY RESOLV RTSP SMTP TELNET TFTP THREADED_RESOLVER TLS_SRP
>> +OPTIONS_DEFAULT= ALTSVC CA_BUNDLE COOKIES GSSAPI_${${SSL_DEFAULT} == base :?BASE :NONE} DICT FTP GOPHER HTTP HTTP2 IMAP NTLM OPENSSL POP3 PROXY RESOLV RTSP SMTP TELNET TFTP THREADED_RESOLVER TLS_SRP
>
> Did you forget to bump PORTREVISION when changing default options?
>
The thinking was that: NTLM is (was) an implicit default because OPENSSL
is an OPTIONS_DEFAULT, and that this fixed a build failure when OpenSSL
was built without DES (a default option), that it wasn't necessary.
Said another way, that it wasn't necessary because it was a noop except
for ports users with the build failure
Happy to bump the portrev if there's a case for it though
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?67545a34-c13d-523f-ebe9-111a86117bd7>