Date: Sun, 16 Jul 2023 14:29:00 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Piotr Kubaj <pkubaj@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: bf0af791ab80 - main - lang/rust: add LTO option Message-ID: <CAFDf7UKNikFy8Qv-c3FZ08gXM0iaESfRVMU5oHrywcDUAhGiyA@mail.gmail.com> In-Reply-To: <202307161059.36GAx0v1016085@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hello Piotr, Very curious to see the effect of rust with lto compiling ports need it, memory, cpu speed, etc. Since LTO is on by default on ports using cargo, is there any plans to turn LTO on on rust himself? Cheers, Piotr Kubaj <pkubaj@freebsd.org> escreveu no dia domingo, 16/07/2023 à(s) 11:59: > The branch main has been updated by pkubaj: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=bf0af791ab80f4f109bfecf4a954bcf94f00947d > > commit bf0af791ab80f4f109bfecf4a954bcf94f00947d > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > AuthorDate: 2023-07-16 10:57:56 +0000 > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > CommitDate: 2023-07-16 10:58:20 +0000 > > lang/rust: add LTO option > --- > lang/rust/Makefile | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/lang/rust/Makefile b/lang/rust/Makefile > index 184c0768b95f..71d8416d34b8 100644 > --- a/lang/rust/Makefile > +++ b/lang/rust/Makefile > @@ -48,7 +48,7 @@ CONFLICTS_INSTALL?= rust-nightly > # ?= to allow users to still overwrite it in make.conf. > TMPDIR?= ${WRKDIR} > > -OPTIONS_DEFINE= DOCS GDB SOURCES WASM > +OPTIONS_DEFINE= DOCS GDB LTO SOURCES WASM > OPTIONS_DEFAULT= SOURCES WASM > > GDB_DESC= Install ports gdb (necessary for debugging rust programs) > @@ -191,7 +191,13 @@ do-configure: > @${ECHO_CMD} 'deny-warnings=false' >> ${WRKSRC}/config.toml > @${ECHO_CMD} 'verbose-tests=true' >> ${WRKSRC}/config.toml > @${ECHO_CMD} 'lld=${_RUST_BUILD_WASM}' >> ${WRKSRC}/config.toml > +.if ${PORT_OPTIONS:MLTO} > + @${ECHO_CMD} 'lto="thin"' >> ${WRKSRC}/config.toml > +.endif > @${ECHO_CMD} '[llvm]' >> ${WRKSRC}/config.toml > +.if ${PORT_OPTIONS:MLTO} > + @${ECHO_CMD} 'thin-lto=true' >> ${WRKSRC}/config.toml > +.endif > .if defined(WITH_CCACHE_BUILD) && !defined(NO_CCACHE) > @${ECHO_CMD} 'ccache="${CCACHE_BIN}"' >> ${WRKSRC}/config.toml > .else > -- Nuno Teixeira FreeBSD Committer (ports) [-- Attachment #2 --] <div dir="ltr"><div>Hello Piotr,</div><div><br></div><div>Very curious to see the effect of rust with lto compiling ports need it, memory, cpu speed, etc.<br></div><div><br></div><div>Since LTO is on by default on ports using cargo, is there any plans to turn LTO on on rust himself?</div><div><br></div><div>Cheers, <br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Piotr Kubaj <<a href="mailto:pkubaj@freebsd.org">pkubaj@freebsd.org</a>> escreveu no dia domingo, 16/07/2023 à(s) 11:59:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The branch main has been updated by pkubaj:<br> <br> URL: <a href="https://cgit.FreeBSD.org/ports/commit/?id=bf0af791ab80f4f109bfecf4a954bcf94f00947d" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/ports/commit/?id=bf0af791ab80f4f109bfecf4a954bcf94f00947d</a><br>; <br> commit bf0af791ab80f4f109bfecf4a954bcf94f00947d<br> Author: Piotr Kubaj <pkubaj@FreeBSD.org><br> AuthorDate: 2023-07-16 10:57:56 +0000<br> Commit: Piotr Kubaj <pkubaj@FreeBSD.org><br> CommitDate: 2023-07-16 10:58:20 +0000<br> <br> lang/rust: add LTO option<br> ---<br> lang/rust/Makefile | 8 +++++++-<br> 1 file changed, 7 insertions(+), 1 deletion(-)<br> <br> diff --git a/lang/rust/Makefile b/lang/rust/Makefile<br> index 184c0768b95f..71d8416d34b8 100644<br> --- a/lang/rust/Makefile<br> +++ b/lang/rust/Makefile<br> @@ -48,7 +48,7 @@ CONFLICTS_INSTALL?= rust-nightly<br> # ?= to allow users to still overwrite it in make.conf.<br> TMPDIR?= ${WRKDIR}<br> <br> -OPTIONS_DEFINE= DOCS GDB SOURCES WASM<br> +OPTIONS_DEFINE= DOCS GDB LTO SOURCES WASM<br> OPTIONS_DEFAULT= SOURCES WASM<br> <br> GDB_DESC= Install ports gdb (necessary for debugging rust programs)<br> @@ -191,7 +191,13 @@ do-configure:<br> @${ECHO_CMD} 'deny-warnings=false' >> ${WRKSRC}/config.toml<br> @${ECHO_CMD} 'verbose-tests=true' >> ${WRKSRC}/config.toml<br> @${ECHO_CMD} 'lld=${_RUST_BUILD_WASM}' >> ${WRKSRC}/config.toml<br> +.if ${PORT_OPTIONS:MLTO}<br> + @${ECHO_CMD} 'lto="thin"' >> ${WRKSRC}/config.toml<br> +.endif<br> @${ECHO_CMD} '[llvm]' >> ${WRKSRC}/config.toml<br> +.if ${PORT_OPTIONS:MLTO}<br> + @${ECHO_CMD} 'thin-lto=true' >> ${WRKSRC}/config.toml<br> +.endif<br> .if defined(WITH_CCACHE_BUILD) && !defined(NO_CCACHE)<br> @${ECHO_CMD} 'ccache="${CCACHE_BIN}"' >> ${WRKSRC}/config.toml<br> .else<br> </blockquote></div><br clear="all"><br><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7UKNikFy8Qv-c3FZ08gXM0iaESfRVMU5oHrywcDUAhGiyA>