Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Jul 2023 19:42:35 +0200
From:      Piotr Kubaj <pkubaj@anongoth.pl>
To:        FreeBSD User <freebsd@walstatt-de.de>
Cc:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 6ad2a9a64f34 - main - ix: remove stale comment
Message-ID:  <ZK2Ui7Dwz0f36dX3@talos>
In-Reply-To: <20230711190349.632481df@thor.intern.walstatt.dynvpn.de>
References:  <202307111645.36BGj5K9072743@gitrepo.freebsd.org> <20230711190349.632481df@thor.intern.walstatt.dynvpn.de>

next in thread | previous in thread | raw e-mail | index | archive | help

--8U6Qche72nN3OQ5P
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 23-07-11 19:03:22, FreeBSD User wrote:
> Am Tue, 11 Jul 2023 16:45:05 GMT
> Piotr Kubaj <pkubaj@FreeBSD.org> schrieb:
>=20
> > The branch main has been updated by pkubaj:
> >=20
> > URL: https://cgit.FreeBSD.org/src/commit/?id=3D6ad2a9a64f34ea3b376c3064=
fcba30b3c8e654dd
> >=20
> > commit 6ad2a9a64f34ea3b376c3064fcba30b3c8e654dd
> > Author:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > AuthorDate: 2023-07-11 16:45:04 +0000
> > Commit:     Piotr Kubaj <pkubaj@FreeBSD.org>
> > CommitDate: 2023-07-11 16:45:04 +0000
> >=20
> >     ix: remove stale comment
> >    =20
> >     Reported by:    Navdeep Parhar
> > ---
> >  sys/dev/ixgbe/if_ix.c | 1 -
> >  1 file changed, 1 deletion(-)
> >=20
> > diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c
> > index 09c0a82279ed..45ab7c27233a 100644
> > --- a/sys/dev/ixgbe/if_ix.c
> > +++ b/sys/dev/ixgbe/if_ix.c
> > @@ -3678,7 +3678,6 @@ ixgbe_if_update_admin_status(if_ctx_t ctx)
> >  			ixgbe_fc_enable(&sc->hw);
> >  			/* Update DMA coalescing config */
> >  			ixgbe_config_dmac(sc);
> > -			/* should actually be negotiated value */
> >  			iflib_link_state_change(ctx, LINK_STATE_UP,
> >  			    ixgbe_link_speed_to_baudrate(adapter->link_speed));
> > =20
> >=20
>=20
> Buildkernel seems to fail due to:
>=20
> [...]
> /usr/src/sys/dev/ixgbe/if_ixv.c:940:37: error: use of undeclared identifi=
er 'adapter'
>                             ixgbe_link_speed_to_baudrate(adapter->link_sp=
eed));
Thanks, fixed now.
>=20
>=20
>=20
> --=20
> O. Hartmann

--8U6Qche72nN3OQ5P
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmStlIsACgkQelmbhSCD
nJ1h0RAAndMinkH7xsu6X6320BY1h8aF0kyo8eCnlh3j+3UGF63ZYVv4fkRx3PVE
llUDc9rfo2qQzEylAP1HtH//InsW7a6jm7BpzH8JScDMve+65QFHKER0aimSbFWp
vEi1qJuoqCB5s77ceJa6a7vgVEU29M2sIOcI5/7Mb2ddz8hGr0neJ4UHI+BOYzYl
ZrqDRu6AyRorG4fFVGHU3nfEgQwSPlyOhL/ovPkpjFPXGx+cMbd+bwedIL5K77+q
lgVJOvYnKASr05KkcKTdLGXOBiZ+Uo74IYr+MrhSnC1D+PBiTmHcdqSRgpVfqRHK
+0QMnATIqNBnT0qT6X9WyZ5gLknxOwj5FIe6bY94yE20xa4p2zSYu7qh6YK7jF8w
0J+wmE/fxBAhjkqey/JgHB20tIKtXv49HenEAs8iiuKtXeiJ+P7zhhZYcO9M/e7y
dggrmndRF2/BgXrUjXgdOIwrUBTPY9YjMtZcNzjpNMmc4S8xhV+JpWnnsafeVW0X
x/+HhWxAXN7dkVzWquqljxJ3HMPTGHTpmxYr/xImJ4sZO/Zw8bWXWyj1IcAQG7wt
OFy0MkO0fDz0h8oNeR5YMwWDSAq8bLrpbmJlbgCOM1No26R70Fd5BVVuBdUvkdr0
2gOz+P1SAF0xC/kCx9uvEpwt0YaCc1+mTtfnHVPc0kO5Bi/CG8o=
=Z6F6
-----END PGP SIGNATURE-----

--8U6Qche72nN3OQ5P--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZK2Ui7Dwz0f36dX3>