Date: Wed, 29 Apr 2009 15:48:57 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: jeff@freebsd.org Cc: Bruce Simpson <bms@incunabulum.net>, pluknet <pluknet@gmail.com>, current@freebsd.org Subject: Re: [head tinderbox] failure on powerpc/powerpc Message-ID: <20090429124857.GD40751@deviant.kiev.zoral.com.ua> In-Reply-To: <49F8460F.7030506@incunabulum.net> References: <20090429104651.8CE537302F@freebsd-current.sentex.ca> <a31046fc0904290511wd4caa8xfdfb3e7389c6b5a6@mail.gmail.com> <49F8460F.7030506@incunabulum.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Apr 29, 2009 at 01:20:31PM +0100, Bruce Simpson wrote:
> pluknet wrote:
> >...
> >>/src/sys/kern/sched_ule.c: In function 'sched_idletd':
> >>/src/sys/kern/sched_ule.c:2546: error: dereferencing pointer to
> >>incomplete type
> >>/src/sys/kern/sched_ule.c:2546: error: 'CG_FLAG_THREAD' undeclared (first
> >>use in this function)
> >>/src/sys/kern/sched_ule.c:2546: error: (Each undeclared identifier is
> >>reported only once
> >>/src/sys/kern/sched_ule.c:2546: error: for each function it appears in.)
> >>*** Error code 1
> >>
> >>
> >
> >This is the only arch without "options SMP" in GENERIC.
> >Global NOTES also define options SCHED_4BSD and thus
> >does not trigger the error (CG_FLAG_THREAD in SMP scope).
> >
> >
> +1, I just saw this on a 'make universe' run affecting the ARM targets.
>
> BMS
The following works for me. The tdq_idled() definition may be #ifdef SMP
too, but I do not see a point. THe CG_FLAG_THREAD is used in sched_idletd(),
and adding more #ifdef SMP would make the code more ugly without any gain.
diff --git a/sys/sys/smp.h b/sys/sys/smp.h
index 05c8642..293f07d 100644
--- a/sys/sys/smp.h
+++ b/sys/sys/smp.h
@@ -16,8 +16,6 @@
#ifndef LOCORE
-#ifdef SMP
-
/*
* Topology of a NUMA or HTT system.
*
@@ -57,6 +55,7 @@ struct cpu_group {
#define CG_FLAG_SMT 0x02 /* New age htt, less crippled. */
#define CG_FLAG_THREAD (CG_FLAG_HTT | CG_FLAG_SMT) /* Any threading. */
+#ifdef SMP
/*
* Convenience routines for building topologies.
*/
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEARECAAYFAkn4TLkACgkQC3+MBN1Mb4hUvgCfWTWtdqqPTA71AAU9yUBspkch
z5oAnjMFPJsM44vQk0cdWZk8Zh+5x9/q
=mLFS
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090429124857.GD40751>