Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Jul 2017 18:03:48 +0200
From:      "Kristof Provost" <kp@FreeBSD.org>
To:        "Ngie Cooper" <yaneurabeya@gmail.com>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r321370 - head/lib/libsysdecode
Message-ID:  <8FA5355F-E374-49BE-B2B2-25351ED827A9@FreeBSD.org>
In-Reply-To: <F8B9F48F-0CFC-480D-8CAF-4891A9A2D907@gmail.com>
References:  <201707221251.v6MCpKn4014224@repo.freebsd.org> <F8B9F48F-0CFC-480D-8CAF-4891A9A2D907@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

On 22 Jul 2017, at 17:42, Ngie Cooper (yaneurabeya) wrote:
> > On Jul 22, 2017, at 5:51 AM, Kristof Provost <kp@FreeBSD.org> wrote:
>>
>> Author: kp
>> Date: Sat Jul 22 12:51:19 2017
>> New Revision: 321370
>> URL: https://svnweb.freebsd.org/changeset/base/321370
>>
>> Log:
>>  Handle WITH/WITHOUT_PF in libsysdecode
>>
>>  Only filter out the PF ioctls if we're building without pf support.
>>  Until now those were always filtered out, so truss did not show 
>> symbolic
>>  names for pf ioctls.
>
>
> Hi Kristof!
> 	'MFC after:	1 week” should have probably be added to this commit.
> 	This change should be MFCed to ^/stable/11 and probably ^/stable/10 
> (in usr.sbin/kdump on 10: 
> https://svnweb.freebsd.org/base/stable/10/usr.bin/kdump/mkioctls?revision=291815&view=markup#l25 
> <https://svnweb.freebsd.org/base/stable/10/usr.bin/kdump/mkioctls?revision=291815&view=markup#l25>).

To be honest I wasn’t planning on MFCing this, because it’s not a 
terribly important issue.
That said, if it’d be useful to you (or anyone else) I’m certainly 
willing to do so.

I’m not sure how much the code changed between 10 and 11, but MFC to 
11 should be easy, and if the changes are not too extensive I can do the 
merge to 10 as well.

Regards,
Kristof




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8FA5355F-E374-49BE-B2B2-25351ED827A9>