Date: Sun, 2 Sep 2012 15:12:01 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Glen Barber <gjb@freebsd.org> Cc: hackers@freebsd.org Subject: Re: [PATCH] head/Makefile.inc1: Fix 'make distributeworld' when defining WITHOUT_GAMES Message-ID: <CAGH67wSEhTqDft7C9VZy4h82xrkjjq7w9Y%2B-apynUMK4Pwycsg@mail.gmail.com> In-Reply-To: <CAGH67wQpgdqnXSeRUnUACQHNWJi-Z9ZEsB6ZQZ7Bf_W2nXyUKg@mail.gmail.com> References: <20120902214616.GB1507@glenbarber.us> <CAGH67wQpgdqnXSeRUnUACQHNWJi-Z9ZEsB6ZQZ7Bf_W2nXyUKg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 2, 2012 at 3:05 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
> On Sun, Sep 2, 2012 at 2:46 PM, Glen Barber <gjb@freebsd.org> wrote:
>> Hi,
>>
>> Attached patch fixes 'make distributeworld' and our 'make release'
>> scripts when WITHOUT_GAMES is set.
>>
>> Can someone please comment/test/commit?
>
> It should be `.if ${MK_GAMES} != "no"`. Other than that, LGTM!
I would also dare to go one step further and remove
`${WORLDTMP}/legacy/usr/games` from BPATH and XPATH when ${MK_GAMES}
== "no" to reduce the number of path lookups done (this should help
speed up the build a bit).
Thanks!
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wSEhTqDft7C9VZy4h82xrkjjq7w9Y%2B-apynUMK4Pwycsg>