Date: Mon, 4 Feb 2019 16:55:40 +0000 From: Andrew Turner <andrew@freebsd.org> To: Li-Wen Hsu <lwhsu@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343713 - in head/sys: amd64/conf arm64/conf Message-ID: <078B413A-80B9-4467-8E32-3D0DB7EDE32B@freebsd.org> In-Reply-To: <CAKBkRUzz16nWf7-Vo=6V44GFYMV2mHBrzju_iyrP1KUNbzbvSw@mail.gmail.com> References: <201902031246.x13CkRY5049231@repo.freebsd.org> <CAKBkRUzz16nWf7-Vo=6V44GFYMV2mHBrzju_iyrP1KUNbzbvSw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This should be fixed in r343746. Andrew > On 4 Feb 2019, at 05:28, Li-Wen Hsu <lwhsu@freebsd.org> wrote: >=20 > On Sun, Feb 3, 2019 at 8:46 PM Andrew Turner <andrew@freebsd.org> = wrote: >>=20 >> Author: andrew >> Date: Sun Feb 3 12:46:27 2019 >> New Revision: 343713 >> URL: https://svnweb.freebsd.org/changeset/base/343713 >>=20 >> Log: >> Enable COVERAGE and KCOV by default on arm64 and amd64. >>=20 >> This allows userspace to trace the kernel using the coverage = sanitizer >> found in clang. It will also allow other coverage tools to be built = as >> modules and attach into the same framework. >>=20 >> Sponsored by: DARPA, AFRL >>=20 >> Modified: >> head/sys/amd64/conf/GENERIC >> head/sys/arm64/conf/GENERIC >>=20 >> Modified: head/sys/amd64/conf/GENERIC >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/amd64/conf/GENERIC Sun Feb 3 11:41:43 2019 = (r343712) >> +++ head/sys/amd64/conf/GENERIC Sun Feb 3 12:46:27 2019 = (r343713) >> @@ -102,8 +102,8 @@ options MALLOC_DEBUG_MAXZONES=3D8 # Separate = malloc(9) >> options VERBOSE_SYSINIT=3D0 # Support = debug.verbose_sysinit, off by default >>=20 >> # Kernel Sanitizers >> -#options COVERAGE # Generic kernel coverage. = Used by KCOV >> -#options KCOV # Kernel Coverage Sanitizer >> +options COVERAGE # Generic kernel coverage. = Used by KCOV >> +options KCOV # Kernel Coverage Sanitizer >> # Warning: KUBSAN can result in a kernel too large for loader to load >> #options KUBSAN # Kernel Undefined Behavior = Sanitizer >>=20 >>=20 >> Modified: head/sys/arm64/conf/GENERIC >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/arm64/conf/GENERIC Sun Feb 3 11:41:43 2019 = (r343712) >> +++ head/sys/arm64/conf/GENERIC Sun Feb 3 12:46:27 2019 = (r343713) >> @@ -94,8 +94,8 @@ options USB_DEBUG # enable = debug msgs >> options VERBOSE_SYSINIT=3D0 # Support = debug.verbose_sysinit, off by default >>=20 >> # Kernel Sanitizers >> -#options COVERAGE # Generic kernel coverage. = Used by KCOV >> -#options KCOV # Kernel Coverage Sanitizer >> +options COVERAGE # Generic kernel coverage. = Used by KCOV >> +options KCOV # Kernel Coverage Sanitizer >> # Warning: KUBSAN can result in a kernel too large for loader to load >> #options KUBSAN # Kernel Undefined Behavior = Sanitizer >=20 > This breaks gcc build: > https://ci.freebsd.org/job/FreeBSD-head-amd64-gcc/8781/console : >=20 > x86_64-unknown-freebsd12.0-gcc: error: unrecognized command line > option '-fsanitize-coverage=3Dtrace-pc,trace-cmp'; did you mean > '-fsanitize-coverage=3Dtrace-pc'? >=20 > We probably need to adjust arguments passed to gcc. >=20 > Li-Wen >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?078B413A-80B9-4467-8E32-3D0DB7EDE32B>