Date: Tue, 24 Aug 2010 10:12:34 +1000 (EST) From: Bruce Evans <brde@optusnet.com.au> To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> Cc: Bruce Cran <bruce@cran.org.uk>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, Bruce Evans <bde@FreeBSD.org>, svn-src-head@FreeBSD.org, Dimitry Andric <dimitry@andric.com> Subject: Re: svn commit: r211304 - head/lib/libutil Message-ID: <20100824100917.C22315@delplex.bde.org> In-Reply-To: <86y6bxybxc.fsf@ds4.des.no> References: <201008141434.o7EEYaSA030301@svn.freebsd.org> <20100815205724.00007e0f@unknown> <86wrrraqk8.fsf@ds4.des.no> <4C7194E6.6080708@andric.com> <86y6bxybxc.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-127678578-1282608754=:22315 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Mon, 23 Aug 2010, [utf-8] Dag-Erling Sm=C3=B8rgrav wrote: > Dimitry Andric <dimitry@andric.com> writes: >> Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: >>> Bruce Cran <bruce@cran.org.uk> writes: >>>> Somewhat related, there are overflow bugs in humanize_number - for >>>> example df(1) fails to display space from a 100PB filesystem >>>> correctly. >>> Patch? :) >> Attached. This makes humanize_number() work properly for all possible >> int64_t values. > > That's awesome! Any way I can convince you to fix expand_number() as > well? I got a detailed explanation of what's wrong with it (both before > and after my commits) from bde@ (cc:ed) in private correspondence; I can > forward it to you if he doesn't mind. OK. I think the final point was that it should go back to supporting signed numbers (only), and that means int64_t ones until scientificize^dehumanize^= W humanize_number() is fixed to support intmax_t ones. Bruce --0-127678578-1282608754=:22315--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100824100917.C22315>