Date: Sun, 16 Sep 2018 23:14:55 +0200 From: "Kristof Provost" <kp@FreeBSD.org> To: "Eric van Gyzen" <eric@vangyzen.net> Cc: "Kurt Jaeger" <pi@freebsd.org>, freebsd-current@freebsd.org, freebsd-net@freebsd.org Subject: Re: Bad DHCP Checksums over VLANs Message-ID: <2D1D4467-2256-40C5-B69F-B9BDC7C7F7D6@FreeBSD.org> In-Reply-To: <794ae64b-54d8-cfde-2e9c-87b3b74e0516@vangyzen.net> References: <9dd3c7f9-d970-5d30-ebf2-c0f40c76011b@vangyzen.net> <20180915060615.GF2118@home.opsec.eu> <794ae64b-54d8-cfde-2e9c-87b3b74e0516@vangyzen.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16 Sep 2018, at 23:05, Eric van Gyzen wrote: > On 9/15/18 1:06 AM, Kurt Jaeger wrote: >> Can you disable all the options of the NIC ? >> >> ifconfig igb0 -rxcsum -txcsum -wol -tso4 -vlanmtu -vlanhwtag >> -vlanhwcsum -vlanhwtso >> >> Try to disable everything that can be disabled, e.g. LRO etc. > > Disabling vlanhwtag works around the problem. > > Also note that only DHCP traffic has this problem. If I assign an > address manually, all traffic flows normally. Maybe the problem is in > the BPF send path. > I had a similar issue, where -vlanhwtag also fixed it. That was on a I210 (gib) card (in a FreeNAS mini XL). Regards, Kristof From owner-freebsd-current@freebsd.org Sun Sep 16 21:15:37 2018 Return-Path: <owner-freebsd-current@freebsd.org> Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23A49108096C for <freebsd-current@mailman.ysv.freebsd.org>; Sun, 16 Sep 2018 21:15:37 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 7FE088175D for <freebsd-current@freebsd.org>; Sun, 16 Sep 2018 21:15:36 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w8GLFQtC049287 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 17 Sep 2018 00:15:29 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w8GLFQtC049287 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w8GLFPaJ049285; Mon, 17 Sep 2018 00:15:25 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 17 Sep 2018 00:15:25 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Manfred Antar <manfredantar@gmail.com> Cc: freebsd-current <freebsd-current@freebsd.org>, mjg@reebsd.org Subject: Re: Current-Alpha6 panic with new support.S AMD64 Message-ID: <20180916211525.GR3161@kib.kiev.ua> References: <10C66C40-045A-4555-8B47-189E5C1FEA13@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <10C66C40-045A-4555-8B47-189E5C1FEA13@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current <freebsd-current.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>; List-Post: <mailto:freebsd-current@freebsd.org> List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-current>, <mailto:freebsd-current-request@freebsd.org?subject=subscribe> X-List-Received-Date: Sun, 16 Sep 2018 21:15:37 -0000 On Sun, Sep 16, 2018 at 01:43:51PM -0700, Manfred Antar wrote: > With r338700 support.S i get panic after rebooting: > > avail memory = 16529514496 (15763 MB) > MADT: Found CPU APIC ID 0 ACPI ID 1: enabled > SMP: Added CPU 0 (AP) > MADT: Found CPU APIC ID 2 ACPI ID 2: enabled > SMP: Added CPU 2 (AP) > MADT: Found CPU APIC ID 1 ACPI ID 3: enabled > SMP: Added CPU 1 (AP) > MADT: Found CPU APIC ID 3 ACPI ID 4: enabled > SMP: Added CPU 3 (AP) > Event timer "LAPIC" quality 100 > kernel trap 9 with interrupts disabled > > > Fatal trap 9: general protection fault while in kernel mode > cpuid = 0; apic id = 00 > instruction pointer = 0x20:0xffffffff80747d86 > stack pointer = 0x28:0xffffffff82451820 > frame pointer = 0x28:0xffffffff82451820 > code segment = base 0x0, limit 0xfffff, type 0x1b > = DPL 0, pres 1, long 1, def32 0, gran 1 > processor eflags = resume, IOPL = 0 > current process = 0 () > [ thread pid 0 tid 0 ] > Stopped at strcmp+0x6: movb (%rsi),%dl > db> bt > Tracing pid 0 tid 0 td 0xffffffff81015180 > strcmp() at strcmp+0x6/frame 0xffffffff82451820 > sysctl_register_oid() at sysctl_register_oid+0x4c/frame 0xffffffff82451b40 > sysctl_add_oid() at sysctl_add_oid+0x20d/frame 0xffffffff82451b90 > et_register() at et_register+0x14d/frame 0xffffffff82451bf0 > native_lapic_init() at native_lapic_init+0x4e3/frame 0xffffffff82451c10 > madt_setup_local() at madt_setup_local+0x26e/frame 0xffffffff82451c40 > apic_setup_local() at apic_setup_local+0x44/frame 0xffffffff82451c50 > mi_startup() at mi_startup+0x118/frame 0xffffffff82451c70 > btext() at btext+0x2c > db> > > With support.S r338683 no problem What is your cpu ? Show first 50 lines from the verbose dmesg. Also please try this patch. diff --git a/sys/amd64/amd64/support.S b/sys/amd64/amd64/support.S index f86d3d11506..5a4e62faba1 100644 --- a/sys/amd64/amd64/support.S +++ b/sys/amd64/amd64/support.S @@ -122,7 +122,6 @@ ENTRY(memmove_std) movq %rdx,%rcx andq $7,%rcx /* any bytes left? */ jne 2f - movq %r9,%rax POP_FRAME_POINTER ret 2:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2D1D4467-2256-40C5-B69F-B9BDC7C7F7D6>