Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 01 Jan 2018 05:21:07 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 224808] New x11-fonts/nerd-fonts-complete 1.2.0
Message-ID:  <bug-224808-13-HtZPTnBf8r@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-224808-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-224808-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224808

Joseph Mingrone <jrm@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jrm@freebsd.org

--- Comment #1 from Joseph Mingrone <jrm@freebsd.org> ---
- You need to start with the line
# $FreeBSD$

- Why not PORTNAME=3Dnerd-fonts, then you can remove GH_PROJECT=3D nerd-fon=
ts.

- COMMENT is too long and should not start with 'A".  Maybe:
COMMENT=3DCollection of over 20 patched fonts

- The block order should conform to 'Order of Variables in Port Makefiles' =
in
the Porter's Handbook.
USES=3D           fonts
USE_GITHUB=3D     yes
GH_ACCOUNT=3D     ryanoasis

NO_ARCH=3D        yes
NO_BUILD=3D       yes

There are pkg-plist issues because of empty directories.  Maybe add this to=
 the
do-install target.

        @${RMDIR} ${STAGEDIR}${FONTSDIR}/ProFont/ProFontWinTweaked/complete=
 \
                ${STAGEDIR}${FONTSDIR}/ProFont/ProFontWinTweaked \
                ${STAGEDIR}${FONTSDIR}/ProFont/profont-x11 \
                ${STAGEDIR}${FONTSDIR}/Terminus/BDF \
                ${STAGEDIR}${FONTSDIR}/Terminus/PCF \
                ${STAGEDIR}${FONTSDIR}/Terminus/PSF \

ports-mgmt/portlint is helpful for detecting issues (but is not perfect).

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-224808-13-HtZPTnBf8r>