Date: Tue, 13 Dec 2011 16:35:06 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Eitan Adler <eadler@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228470 - head/sys/kern Message-ID: <20111213153506.GC1659@garage.freebsd.pl> In-Reply-To: <201112131400.pBDE0S6M053401@svn.freebsd.org> References: <201112131400.pBDE0S6M053401@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--mvpLiMfbWzRoNl4x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 13, 2011 at 02:00:28PM +0000, Eitan Adler wrote: > Author: eadler (ports committer) > Date: Tue Dec 13 14:00:27 2011 > New Revision: 228470 > URL: http://svn.freebsd.org/changeset/base/228470 >=20 > Log: > - Add a sysctl to allow non-root users the ability to set idle > priorities. [...] I'd suggest using consistent style with those two: [...] > + unprivileged_idprio =3D=3D 0)) { [...] > + !unprivileged_idprio)) { [...] Because it should be either 0 or 1, the latter is better. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --mvpLiMfbWzRoNl4x Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk7ncKoACgkQForvXbEpPzTNYgCgl4/ZJrmmjPmntJy4+hf5v7Oz /B0An2U19PGf6a33HWq2j30qc+9XNUWF =ymwP -----END PGP SIGNATURE----- --mvpLiMfbWzRoNl4x--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111213153506.GC1659>