Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Jun 2026 19:21:06 +0000
From:      bugzilla-noreply@freebsd.org
To:        bugs@FreeBSD.org
Subject:   [Bug 295103] tpm_tis driver reports "Failed to switch to ready state"
Message-ID:  <bug-295103-227-oMdUiyWWmE@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-295103-227@https.bugs.freebsd.org/bugzilla/>

index | next in thread | previous in thread | raw e-mail

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295103

--- Comment #6 from Benoit SANSONI <benoit.sansoni@gmail.com> ---
1. 

You are right I left this debug (device_printf) to checkout the viddid value in
dmesg.
In addition, the viddid value could be used also in the code to apply fix only
for the ST33KTPM2X32CKE3.
But I did not do it in the current code.
So the viddid if the debug is removed, will not be used and could provoke a
warning during build process.

Currently, for sure it can be removed.

2.

Oups, sorry for the coding style!
Easy to change in this case.

3.

Your proposal "/* Return device to ready state; required by ST33KTPM2X32CKE3.
*/" is correct.

4. 

FYI, I explained before in this thread, I applied this patch to the kernel of
the FreeBSD 14.2.
By reading this code review https://reviews.freebsd.org/D45069, it seems that
TPM_WRITE_4 is equivalent to WR4, and TPM_WRITE_BARRIER is equivalent to the
line "bus_barrier(sc->mem_res, TPM_STS, 4, BUS_SPACE_BARRIER_WRITE);"

Let me know whether it answer to your question. Or I missed something.

-- 
You are receiving this mail because:
You are the assignee for the bug.

home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-295103-227-oMdUiyWWmE>