Date: Tue, 29 Dec 2020 11:51:57 -0600 From: Kyle Evans <kevans@freebsd.org> To: Jessica Clarke <jrtc27@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: git: ee938b20335d - main - kern: efirt: correct configuration table entry size Message-ID: <CACNAnaHg%2BTSf-qYmDLH82M%2B%2BQSawBSHHu=TrJs6tdhwikgn1Vw@mail.gmail.com> In-Reply-To: <E4CC4F44-F314-4D53-BC87-747A756323D9@freebsd.org> References: <202012291739.0BTHd2ji001052@gitrepo.freebsd.org> <E4CC4F44-F314-4D53-BC87-747A756323D9@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 29, 2020 at 11:48 AM Jessica Clarke <jrtc27@freebsd.org> wrote:
>
> On 29 Dec 2020, at 17:39, Kyle Evans <kevans@FreeBSD.org> wrote:
> > diff --git a/sys/sys/efi.h b/sys/sys/efi.h
> > index b9f31454efff..220509853cb2 100644
> > --- a/sys/sys/efi.h
> > +++ b/sys/sys/efi.h
> > @@ -52,7 +52,7 @@ typedef unsigned long efi_status;
> >
> > struct efi_cfgtbl {
> > struct uuid ct_uuid;
> > - uint64_t ct_data;
> > + void *ct_data;
>
> Hm, this should probably be a u_long/vm_offset_t/vm_paddr_t (though the
> tables are unlikely to be in places where you need PAE so even if
> technically correct, vm_paddr_t probably just makes things more awkward
> for no gain) given it's not a real pointer that can be dereferenced.
>
I don't really have strong feelings either way; I originally pushed it
to void* to match edk2 because I was entertaining the thought of just
using edk2's definitions instead anyways, but I got distracted and did
not get back around to deciding if that was a reasonable idea or not.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaHg%2BTSf-qYmDLH82M%2B%2BQSawBSHHu=TrJs6tdhwikgn1Vw>